Don't panic in case of other error types in NewtUsage

m-gorecki · kasjer · commit 1686c67862d9 · 2024-04-26T15:12:31.000+02:00
It does not make sense to panic before printing error
diff --git a/newt/cli/util.go b/newt/cli/util.go
@@ -50,8 +50,6 @@ func NewtUsage(cmd *cobra.Command, err error) {
 			log.Debugf("%+v", err)
 		} else if ne, ok := err.(*util.NewtError); ok {
 			log.Debugf("%s", ne.StackTrace)
-		} else {
-			panic(fmt.Sprintf("unexpected error type: %T", err))
 		}
 
 		fmt.Fprintf(os.Stderr, "Error: %s\n", err.Error())

Original file line number	Diff line number	Diff line change
`@@ -50,8 +50,6 @@ func NewtUsage(cmd *cobra.Command, err error) {`
`50`	`50`	`log.Debugf("%+v", err)`
`51`	`51`	`} else if ne, ok := err.(*util.NewtError); ok {`
`52`	`52`	`log.Debugf("%s", ne.StackTrace)`
`53`		`- } else {`
`54`		`- panic(fmt.Sprintf("unexpected error type: %T", err))`
`55`	`53`	`}`
`56`	`54`
`57`	`55`	`fmt.Fprintf(os.Stderr, "Error: %s\n", err.Error())`