Using nested if blocks rather than ternary operator #8433 (comment)

Author: jglick

java/maven.junit/src/org/netbeans/modules/maven/junit/JUnitOutputListenerProvider.java

@@ -331,11 +331,13 @@ private String getReportsDirectory(String groupId, String artifactId, String goa
         MavenProject currentProject = null;
         // get maven module from context if available
         OutputVisitor.Context context = visitor.getContext();
-        Project cp = context != null ? context.getCurrentProject() : null;
-        if (cp != null) {
-            NbMavenProject subProject = cp.getLookup().lookup(NbMavenProject.class);
-            if (subProject != null) {
-                currentProject = subProject.getMavenProject();
+        if (context != null) {
+            Project cp = context.getCurrentProject();
+            if (cp != null) {
+                NbMavenProject subProject = cp.getLookup().lookup(NbMavenProject.class);
+                if (subProject != null) {
+                    currentProject = subProject.getMavenProject();
+                }
             }
         }
         if (currentProject == null) {
@@ -598,13 +600,19 @@ private boolean usingJUnit4(MavenProject prj) { // SUREFIRE-724
             generateTest();
         }
         OutputVisitor.Context context = visitor.getContext();
-        Project currentProject = context != null ? context.getCurrentProject() : null;
-        File outputDir = currentProject != null ? project2outputDirs.remove(currentProject) : null;
-        TestSession session = outputDir != null ? outputDir2sessions.remove(outputDir) : null;
-        if (session != null) {
-            CoreManager junitManager = getManagerProvider();
-            if (junitManager != null) {
-                junitManager.sessionFinished(session);
+        if (context != null) {
+            Project currentProject = context.getCurrentProject();
+            if (currentProject != null) {
+                File outputDir = project2outputDirs.remove(currentProject);
+                if (outputDir != null) {
+                    TestSession session = outputDir2sessions.remove(outputDir);
+                    if (session != null) {
+                        CoreManager junitManager = getManagerProvider();
+                        if (junitManager != null) {
+                            junitManager.sessionFinished(session);
+                        }
+                    }
+                }
             }
         }
         runningTestClass = null;
@@ -643,28 +651,30 @@ static Trouble constructTrouble(@NonNull String type, @NullAllowed String messag
 
     public @Override void sequenceFail(String sequenceId, OutputVisitor visitor) {
         OutputVisitor.Context context = visitor.getContext();
-        Project currentProject = context != null ? context.getCurrentProject() : null;
-        LOG.log(Level.FINE, "Got sequenceFail: {0}, line {1}", new Object[] { currentProject, visitor.getLine() });
-        // try to get the failed test class. How can this be solved if it is not the first one in the list?
-        if (currentProject != null && surefireRunningInParallel) {
-            String saveRunningTestClass = runningTestClass;
-            
-            for (String s : runningTestClassesInParallel) {
-                File outputDir = locateOutputDirAndWait(s, false);
-                // match the output dir to the project
-                if (outputDir != null) {
-                    Project outputOwner = FileOwnerQuery.getOwner(FileUtil.toFileObject(outputDir));
-                    if (outputOwner == currentProject) {
-                        LOG.log(Level.FINE, "Found unfinished test {0} in {1}, trying to finish", new Object[] { s, currentProject });
-                        runningTestClass  = s;
-                        if (Objects.equals(saveRunningTestClass, s)) {
-                            saveRunningTestClass = null;
+        if (context != null) {
+            Project currentProject = context.getCurrentProject();
+            LOG.log(Level.FINE, "Got sequenceFail: {0}, line {1}", new Object[] {currentProject, visitor.getLine()});
+            // try to get the failed test class. How can this be solved if it is not the first one in the list?
+            if (currentProject != null && surefireRunningInParallel) {
+                String saveRunningTestClass = runningTestClass;
+
+                for (String s : runningTestClassesInParallel) {
+                    File outputDir = locateOutputDirAndWait(s, false);
+                    // match the output dir to the project
+                    if (outputDir != null) {
+                        Project outputOwner = FileOwnerQuery.getOwner(FileUtil.toFileObject(outputDir));
+                        if (outputOwner == currentProject) {
+                            LOG.log(Level.FINE, "Found unfinished test {0} in {1}, trying to finish", new Object[] {s, currentProject});
+                            runningTestClass = s;
+                            if (Objects.equals(saveRunningTestClass, s)) {
+                                saveRunningTestClass = null;
+                            }
+                            generateTest();
                         }
-                        generateTest();
                     }
                 }
+                runningTestClass = saveRunningTestClass;
             }
-            runningTestClass = saveRunningTestClass;
         }
         sequenceEnd(sequenceId, visitor);
     }