- cleanup, add more comment info for composition expression

Author: haidubogdan

php/php.editor/src/org/netbeans/modules/php/editor/lexer/LexUtilities.java

@@ -624,7 +624,7 @@ public static int findStartTokenOfExpression(TokenSequence ts) {
                     break;
                 }
             } else if (token.id() == PHPTokenId.PHP_OPERATOR && TokenUtilities.textEquals(token.text(), "|>")) { // NOI18N
-                //pipe operator
+                //PHP 8.5 pipe operator
                 start = ts.offset();
                 break;
             } else if (balance == 1 && token.id() == PHPTokenId.PHP_STRING) {

php/php.editor/src/org/netbeans/modules/php/editor/parser/PHP5ErrorHandlerImpl.java

@@ -398,6 +398,7 @@ public static String getTokenTextForm(int token) {
                 case ASTPHP5Symbols.T_YIELD_FROM : text = "yield from"; break; //NOI18N
                 case ASTPHP5Symbols.T_READONLY : text = "readonly"; break; //NOI18N PHP 8.1
                 //skiping T_PIPE = "|>" PHP 8.5 as it doesn't bring much to the expected tokens error message
+                // and it breaks multiple unit tests which displayes the expected tokens list
                 default:
                     //no-op
             }

php/php.editor/src/org/netbeans/modules/php/editor/parser/astnodes/Assignment.java

@@ -39,7 +39,6 @@ public enum Type {
         MOD_EQUAL("%="), //NOI18N
         AND_EQUAL("&="), //NOI18N
         OR_EQUAL("|="), //NOI18N
-        PIPE("|>"), //NOI18N
         XOR_EQUAL("^="), //NOI18N
         SL_EQUAL("<<="), //NOI18N
         SR_EQUAL(">>="), //NOI18N

php/php.editor/src/org/netbeans/modules/php/editor/parser/astnodes/CompositionExpression.java

@@ -18,10 +18,21 @@
  */
 package org.netbeans.modules.php.editor.parser.astnodes;
 
-
+/**
+ * Represents a function composition expression
+ * chaining multiple callables from left to right
+ * It's marked by the pipe operator "|>"
+ * @see https://wiki.php.net/rfc/pipe-operator-v3
+ * <pre>
+ * $a |> strtoupper(...)
+ * $a |> trim(...)
+ * </pre>
+ * 
+ */
 public class CompositionExpression extends Expression {
 
     /**
+     * Operator type used for the composition expression
      * possible rfc with using "+" for composition
      * https://wiki.php.net/rfc/function-composition
      */

php/php.editor/src/org/netbeans/modules/php/editor/verification/IncorrectFunctionCompositionHintError.java

@@ -24,7 +24,6 @@
 import java.util.List;
 import org.netbeans.api.annotations.common.NullAllowed;
 import org.netbeans.modules.csl.api.Hint;
-import org.netbeans.modules.csl.api.HintFix;
 import org.netbeans.modules.csl.api.OffsetRange;
 import org.netbeans.modules.csl.spi.support.CancelSupport;
 import org.netbeans.modules.php.api.PhpVersion;

php/php.editor/src/org/netbeans/modules/php/editor/verification/PHP82UnhandledError.java

@@ -32,8 +32,6 @@
 import org.netbeans.modules.php.editor.parser.PHPParseResult;
 import org.netbeans.modules.php.editor.parser.astnodes.ASTNode;
 import org.netbeans.modules.php.editor.parser.astnodes.ClassDeclaration;
-import org.netbeans.modules.php.editor.parser.astnodes.CompositionExpression;
-import org.netbeans.modules.php.editor.parser.astnodes.ConditionalExpression;
 import org.netbeans.modules.php.editor.parser.astnodes.ConstantDeclaration;
 import org.netbeans.modules.php.editor.parser.astnodes.Statement;
 import org.netbeans.modules.php.editor.parser.astnodes.TraitDeclaration;

php/php.editor/src/org/netbeans/modules/php/editor/verification/PHP83UnhandledError.java

@@ -36,7 +36,6 @@
 import org.netbeans.modules.php.editor.parser.astnodes.Assignment;
 import org.netbeans.modules.php.editor.parser.astnodes.ClassInstanceCreation;
 import org.netbeans.modules.php.editor.parser.astnodes.ClassName;
-import org.netbeans.modules.php.editor.parser.astnodes.CompositionExpression;
 import org.netbeans.modules.php.editor.parser.astnodes.ConditionalExpression;
 import org.netbeans.modules.php.editor.parser.astnodes.ConstantDeclaration;
 import org.netbeans.modules.php.editor.parser.astnodes.ConstantVariable;

php/php.editor/src/org/netbeans/modules/php/editor/verification/PHP84UnhandledError.java

@@ -31,7 +31,6 @@
 import org.netbeans.modules.php.editor.parser.astnodes.ASTNode;
 import org.netbeans.modules.php.editor.parser.astnodes.BodyDeclaration.Modifier;
 import org.netbeans.modules.php.editor.parser.astnodes.ClassInstanceCreationVariable;
-import org.netbeans.modules.php.editor.parser.astnodes.CompositionExpression;
 import org.netbeans.modules.php.editor.parser.astnodes.FieldsDeclaration;
 import org.netbeans.modules.php.editor.parser.astnodes.FormalParameter;
 import org.netbeans.modules.php.editor.parser.astnodes.FunctionDeclaration;
@@ -146,14 +145,6 @@ public void visit(MethodDeclaration node) {
             super.visit(node);
         }
 
-        @Override
-        public void visit(CompositionExpression node) {
-            if (CancelSupport.getDefault().isCancelled()) {
-                return;
-            }
-            createError(node);
-        }
-
         private void checkSetVisibility(MethodDeclaration node) {
             if (CodeUtils.isConstructor(node)) {
                 FunctionDeclaration function = node.getFunction();

php/php.editor/src/org/netbeans/modules/php/editor/verification/PHP85UnhandledError.java

@@ -92,6 +92,7 @@ public void visit(CompositionExpression node) {
                 return;
             }
 
+            //composition expression are available since PHP 8.5
             createError(node);
         }