Custom Action not picking the icon nor shortcut in menus

[stefanofornari]

Apache NetBeans version

Apache NetBeans 27

What happened

As per all documentation I have found and in particular How do i add an icon to the context menu, The following action should show in the project context menu the icon and the shortcut. None are actually displayed as per the screenshot.

@ActionID(
    category = "Edit",
    id = "com.example.SomeAction"
)
@ActionRegistration(
    iconBase = "icons/restart.png",
    displayName = "#CTL_SomeAction",
    lazy = true
)
@ActionReferences({
    @ActionReference(path = "Shortcuts", name = "DOS-K"),
    @ActionReference(path = "Projects/Actions", position = 100),
})
@Messages("CTL_SomeAction=Some Action")
public final class SomeAction
    extends AbstractAction
    implements ActionListener, Presenter.Popup {

    @StaticResource
    private static final String ICON = "icons/restart.png";
    private static final long serialVersionUID = 1L;
    private final LookupListener lookupListener;
    private final Lookup.Result<Project> result;

    public SomeAction() {
        putValue(SMALL_ICON, ImageUtilities.loadImageIcon(ICON, false));
        putValue(NAME, Bundle.CTL_SomeAction());
        putValue("iconBase", ICON);
        result = Utilities.actionsGlobalContext().lookupResult(Project.class);
        this.lookupListener = new LookupListener() {

            @Override
            public void resultChanged(LookupEvent ev) {
                EventQueue.invokeLater(new Runnable() {

                    @Override
                    public void run() {
                        setEnabled(!result.allInstances().isEmpty());
                    }
                });
            }
        };
        result.addLookupListener(WeakListeners.create(LookupListener.class, this.lookupListener, result));
        this.lookupListener.resultChanged(null);
    }

    @Override
    public void actionPerformed(ActionEvent e) {
        Logger.getLogger("com.example").info("actionPerformed");
        Action action = FileUtil.getConfigObject("Actions/Edit/com-example-SomeAction.instance", Action.class);
        KeyStroke ks = action != null ? (KeyStroke) action.getValue(Action.ACCELERATOR_KEY) : null;
        javax.swing.JOptionPane.showMessageDialog(null, "Hello! " + ks);
    }

    @Override
    public JMenuItem getPopupPresenter() {
        Logger.getLogger("com.example").info("getPopupPresenter");
        return new JMenuItem(this);
    }
}

Language / Project Type / NetBeans Component

NetBeans Platform

How to reproduce

use the code above. I have attached a simple project too.

action.zip

Did this work correctly in an earlier version?

No / Don't know

Operating System

Linux Ubuntu

JDK

any

Apache NetBeans packaging

Apache NetBeans binary zip

Anything else

I can help debugging provided some directions

Are you willing to submit a pull request?

Yes

[ramiswailem]

Make sure your icons folder is inside src/main/resources/ so the path becomes icons/restart.png.

[stefanofornari]

Hi,
yes it is in src/main/resources as per the attached project. BTW, investigating the issue, I think some NB actions suffer the same issue, for example sho IDE Log.

[neilcsmith-net]

Why are you using lazy=true ? See https://bits.netbeans.org/27/javadoc/org-openide-awt/org/openide/awt/ActionRegistration.html#lazy()

I think some NB actions suffer the same issue, for example sho IDE Log.

No, it doesn't. It sets iconInMenu=false.

Moving this into a discussion. These are usage questions, not an issue with the platform.

[stefanofornari]

[edited]
I had checked it before and I set it because otherwise NB complains.

setting it to false, however make the trick and now the icon is showing. Now the issue is only with the shortcut. I would expect to show as well con the menu.