Change parameter order for runDebug, compat with NBLS codelenses. #8173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinBalin
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NBLS action "run with Micronaut: dev mode" throws Internal error.
PR #7979 introduced additional parameters for
.run.test,.debug.test,.run.singleand.debug.single- thenestedClassparameter was however added beforelaunchConfiguration.The relevant part in NBLS which produce Code Lenses was not adapted.
The issue surfaces only if there are multiple project configurations in the project that provide Run/Debug action overrides; for Micronaut, the Micronaut module supplies a Project Configuration that (re) define Run action. The action is available from the editor code lens on the main class main() method, for example.
It seems that a minimal change is to change the parameters added by PR #7979 and order them after the existing ones, which allows pre-existing code to function.
I had to adapt the
testAdapter.tscode that actually works with nested classes and uses the introduced parameter. There was one other usage intestAdaptersbut as it passedudefinedto both configuration AND nestedclass, it can stay as it is.When reviewing, please consult also the original PR code - there are 2 places that invoke the changed NBLS commands.