Skip to content

Commit 08be6ba

Browse files
committed
MINIFICPP-2675 Move Elasticsearch tests to modular docker tests
1 parent 25f9b07 commit 08be6ba

File tree

18 files changed

+334
-442
lines changed

18 files changed

+334
-442
lines changed

docker/RunBehaveTests.sh

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -201,4 +201,5 @@ exec \
201201
"${docker_dir}/../extensions/llamacpp/tests/features" \
202202
"${docker_dir}/../extensions/opc/tests/features" \
203203
"${docker_dir}/../extensions/kafka/tests/features" \
204-
"${docker_dir}/../extensions/couchbase/tests/features"
204+
"${docker_dir}/../extensions/couchbase/tests/features" \
205+
"${docker_dir}/../extensions/elasticsearch/tests/features"

docker/test/integration/cluster/ContainerStore.py

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,6 @@
2626
from .containers.PostgreSQLServerContainer import PostgreSQLServerContainer
2727
from .containers.MqttBrokerContainer import MqttBrokerContainer
2828
from .containers.SplunkContainer import SplunkContainer
29-
from .containers.ElasticsearchContainer import ElasticsearchContainer
30-
from .containers.OpensearchContainer import OpensearchContainer
3129
from .containers.SyslogUdpClientContainer import SyslogUdpClientContainer
3230
from .containers.SyslogTcpClientContainer import SyslogTcpClientContainer
3331
from .containers.MinifiAsPodInKubernetesCluster import MinifiAsPodInKubernetesCluster
@@ -179,22 +177,6 @@ def acquire_container(self, context, container_name: str, engine='minifi-cpp', c
179177
network=self.network,
180178
image_store=self.image_store,
181179
command=command))
182-
elif engine == 'elasticsearch':
183-
return self.containers.setdefault(container_name,
184-
ElasticsearchContainer(feature_context=feature_context,
185-
name=container_name,
186-
vols=self.vols,
187-
network=self.network,
188-
image_store=self.image_store,
189-
command=command))
190-
elif engine == 'opensearch':
191-
return self.containers.setdefault(container_name,
192-
OpensearchContainer(feature_context=feature_context,
193-
name=container_name,
194-
vols=self.vols,
195-
network=self.network,
196-
image_store=self.image_store,
197-
command=command))
198180
elif engine == "syslog-udp-client":
199181
return self.containers.setdefault(container_name,
200182
SyslogUdpClientContainer(

docker/test/integration/cluster/DockerTestCluster.py

Lines changed: 0 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@
2828
from .MinifiControllerExecutor import MinifiControllerExecutor
2929
from .checkers.AwsChecker import AwsChecker
3030
from .checkers.AzureChecker import AzureChecker
31-
from .checkers.ElasticSearchChecker import ElasticSearchChecker
3231
from .checkers.GcsChecker import GcsChecker
3332
from .checkers.PostgresChecker import PostgresChecker
3433
from .checkers.PrometheusChecker import PrometheusChecker
@@ -47,7 +46,6 @@ def __init__(self, context, feature_id):
4746
self.container_store = ContainerStore(self.container_communicator.create_docker_network(feature_id), context.image_store, context.kubernetes_proxy, feature_id=feature_id)
4847
self.aws_checker = AwsChecker(self.container_communicator)
4948
self.azure_checker = AzureChecker(self.container_communicator)
50-
self.elastic_search_checker = ElasticSearchChecker(self.container_communicator)
5149
self.gcs_checker = GcsChecker(self.container_communicator)
5250
self.postgres_checker = PostgresChecker(self.container_communicator)
5351
self.splunk_checker = SplunkChecker(self.container_communicator)
@@ -262,26 +260,6 @@ def is_gcs_bucket_empty(self, container_name):
262260
container_name = self.container_store.get_container_name_with_postfix(container_name)
263261
return self.gcs_checker.is_gcs_bucket_empty(container_name)
264262

265-
def is_elasticsearch_empty(self, container_name):
266-
container_name = self.container_store.get_container_name_with_postfix(container_name)
267-
return self.elastic_search_checker.is_elasticsearch_empty(container_name)
268-
269-
def create_doc_elasticsearch(self, container_name, index_name, doc_id):
270-
container_name = self.container_store.get_container_name_with_postfix(container_name)
271-
return self.elastic_search_checker.create_doc_elasticsearch(container_name, index_name, doc_id)
272-
273-
def check_elastic_field_value(self, container_name, index_name, doc_id, field_name, field_value):
274-
container_name = self.container_store.get_container_name_with_postfix(container_name)
275-
return self.elastic_search_checker.check_elastic_field_value(container_name, index_name, doc_id, field_name, field_value)
276-
277-
def elastic_generate_apikey(self, elastic_container_name):
278-
elastic_container_name = self.container_store.get_container_name_with_postfix(elastic_container_name)
279-
return self.elastic_search_checker.elastic_generate_apikey(elastic_container_name)
280-
281-
def add_elastic_user_to_opensearch(self, container_name):
282-
container_name = self.container_store.get_container_name_with_postfix(container_name)
283-
return self.elastic_search_checker.add_elastic_user_to_opensearch(container_name)
284-
285263
def check_query_results(self, postgresql_container_name, query, number_of_rows, timeout_seconds):
286264
postgresql_container_name = self.container_store.get_container_name_with_postfix(postgresql_container_name)
287265
return self.postgres_checker.check_query_results(postgresql_container_name, query, number_of_rows, timeout_seconds)

docker/test/integration/cluster/checkers/ElasticSearchChecker.py

Lines changed: 0 additions & 50 deletions
This file was deleted.

docker/test/integration/cluster/containers/ElasticsearchContainer.py

Lines changed: 0 additions & 101 deletions
This file was deleted.

docker/test/integration/cluster/containers/OpensearchContainer.py

Lines changed: 0 additions & 80 deletions
This file was deleted.

docker/test/integration/features/MiNiFi_integration_test_driver.py

Lines changed: 0 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -70,16 +70,6 @@ def start_splunk(self, context):
7070
assert self.cluster.wait_for_container_startup_to_finish('splunk') or self.cluster.log_app_output()
7171
assert self.cluster.enable_splunk_hec_indexer('splunk', 'splunk_hec_token') or self.cluster.log_app_output()
7272

73-
def start_elasticsearch(self, context):
74-
self.cluster.acquire_container(context=context, name='elasticsearch', engine='elasticsearch')
75-
self.cluster.deploy_container('elasticsearch')
76-
assert self.cluster.wait_for_container_startup_to_finish('elasticsearch') or self.cluster.log_app_output()
77-
78-
def start_opensearch(self, context):
79-
self.cluster.acquire_container(context=context, name='opensearch', engine='opensearch')
80-
self.cluster.deploy_container('opensearch')
81-
assert self.cluster.wait_for_container_startup_to_finish('opensearch') or self.cluster.log_app_output()
82-
8373
def start_minifi_c2_server(self, context):
8474
self.cluster.acquire_container(context=context, name="minifi-c2-server", engine="minifi-c2-server")
8575
self.cluster.deploy_container('minifi-c2-server')
@@ -325,21 +315,6 @@ def check_google_cloud_storage(self, gcs_container_name, content):
325315
def check_empty_gcs_bucket(self, gcs_container_name):
326316
assert self.cluster.is_gcs_bucket_empty(gcs_container_name) or self.cluster.log_app_output()
327317

328-
def check_empty_elastic(self, elastic_container_name):
329-
assert self.cluster.is_elasticsearch_empty(elastic_container_name) or self.cluster.log_app_output()
330-
331-
def elastic_generate_apikey(self, elastic_container_name):
332-
return self.cluster.elastic_generate_apikey(elastic_container_name) or self.cluster.log_app_output()
333-
334-
def create_doc_elasticsearch(self, elastic_container_name, index_name, doc_id):
335-
assert self.cluster.create_doc_elasticsearch(elastic_container_name, index_name, doc_id) or self.cluster.log_app_output()
336-
337-
def check_elastic_field_value(self, elastic_container_name, index_name, doc_id, field_name, field_value):
338-
assert self.cluster.check_elastic_field_value(elastic_container_name, index_name, doc_id, field_name, field_value) or self.cluster.log_app_output()
339-
340-
def add_elastic_user_to_opensearch(self, container_name):
341-
assert self.cluster.add_elastic_user_to_opensearch(container_name) or self.cluster.log_app_output()
342-
343318
def check_minifi_log_contents(self, line, timeout_seconds=60, count=1):
344319
self.check_container_log_contents("minifi-cpp", line, timeout_seconds, count)
345320

0 commit comments

Comments
 (0)