Review update

Author: lordgamez

CONTROLLERS.md

@@ -282,7 +282,7 @@ In the list below, the names of required properties appear in bold. Any other pr
 
 ### Description
 
-Reads Sparkplug B messages and turns them into individual Record objects. The reader expects a single Sparkplug B payload in a read operation, which is a protobuf-encoded binary message. This reader is typically used with MQTT processors like ConsumeMQTT.
+Reads Sparkplug B messages and turns them into individual Record objects. The reader expects a single Sparkplug B payload in a read operation, which is a protobuf-encoded binary message. This reader is designed to be used with ConsumeMQTT, since Sparkplug B is an MQTT-based protocol.
 
 ### Properties
 

PROCESSORS.md

@@ -390,7 +390,7 @@ In the list below, the names of required properties appear in bold. Any other pr
 
 ### Description
 
-This Processor gets the contents of a FlowFile from a MQTT broker for a specified topic. The the payload of the MQTT message becomes content of a FlowFile
+This Processor gets the contents of a FlowFile from a MQTT broker for a specified topic. The the payload of the MQTT message becomes content of a FlowFile. If Record Reader and Record Writer are set, then the MQTT message specific attributes are not set in the flow file, because different attributes can be set for different records. In this case if Add Attributes As Fields is set to true, the attributes will be added to each record as fields.
 
 ### Properties
 

docker/test/integration/features/steps/steps.py

@@ -438,9 +438,9 @@ def step_impl(context):
 
 @given("a SparkplugBReader controller service is set up")
 def step_impl(context):
-    json_record_set_reader = SparkplugBReader("SparkplugBReader")
+    sparkplug_record_set_reader = SparkplugBReader("SparkplugBReader")
     container = context.test.acquire_container(context=context, name="minifi-cpp-flow")
-    container.add_controller(json_record_set_reader)
+    container.add_controller(sparkplug_record_set_reader)
 
 
 @when("a test Sparkplug payload is published to the topic \"{topic}\"")

extensions/mqtt/controllers/SparkplugBReader.h

@@ -33,7 +33,8 @@ class SparkplugBReader final : public core::RecordSetReaderImpl {
   ~SparkplugBReader() override = default;
 
   EXTENSIONAPI static constexpr const char* Description = "Reads Sparkplug B messages and turns them into individual Record objects. "
-      "The reader expects a single Sparkplug B payload in a read operation, which is a protobuf-encoded binary message. This reader is typically used with MQTT processors like ConsumeMQTT.";
+      "The reader expects a single Sparkplug B payload in a read operation, which is a protobuf-encoded binary message. This reader is designed to be used with ConsumeMQTT, "
+      "since Sparkplug B is an MQTT-based protocol.";
 
   EXTENSIONAPI static constexpr auto Properties = std::array<core::PropertyReference, 0>{};
 

extensions/mqtt/processors/ConsumeMQTT.h

@@ -47,7 +47,8 @@ class ConsumeMQTT : public processors::AbstractMQTTProcessor {
   }
 
   EXTENSIONAPI static constexpr const char* Description = "This Processor gets the contents of a FlowFile from a MQTT broker for a specified topic. "
-      "The the payload of the MQTT message becomes content of a FlowFile";
+      "The the payload of the MQTT message becomes content of a FlowFile. If Record Reader and Record Writer are set, then the MQTT message specific attributes are not set in the flow file, "
+      "because different attributes can be set for different records. In this case if Add Attributes As Fields is set to true, the attributes will be added to each record as fields.";
 
   EXTENSIONAPI static constexpr auto Topic = core::PropertyDefinitionBuilder<>::createProperty("Topic")
       .withDescription("The topic to subscribe to.")
@@ -125,8 +126,8 @@ class ConsumeMQTT : public processors::AbstractMQTTProcessor {
   EXTENSIONAPI static constexpr auto IsRetainedOutputAttribute = core::OutputAttributeDefinition<0>{"mqtt.isRetained", {},
       "Whether or not this message was from a current publisher, or was \"retained\" by the server as the last message published on the topic."};
   EXTENSIONAPI static constexpr auto RecordCountOutputAttribute = core::OutputAttributeDefinition<0>{"record.count", {}, "The number of records received"};
-  EXTENSIONAPI static constexpr auto OutputAttributes = std::array<core::OutputAttributeReference, 7>{BrokerOutputAttribute, TopicOutputAttribute, TopicSegmentOutputAttribute,
-      QosOutputAttribute, IsDuplicateOutputAttribute, IsRetainedOutputAttribute, RecordCountOutputAttribute};
+  EXTENSIONAPI static constexpr auto OutputAttributes = std::to_array<core::OutputAttributeReference>({BrokerOutputAttribute, TopicOutputAttribute, TopicSegmentOutputAttribute,
+      QosOutputAttribute, IsDuplicateOutputAttribute, IsRetainedOutputAttribute, RecordCountOutputAttribute});
 
   EXTENSIONAPI static constexpr bool SupportsDynamicProperties = false;
   EXTENSIONAPI static constexpr bool SupportsDynamicRelationships = false;