Skip to content

Commit a258196

Browse files
committed
refactor(hf): rename service directory and feature with backward compatible alias
1 parent d44fbf4 commit a258196

File tree

18 files changed

+33
-28
lines changed

18 files changed

+33
-28
lines changed

.github/workflows/ci_core.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -190,7 +190,7 @@ jobs:
190190
# FIXME how to support HDFS services in other platforms?
191191
# services-hdfs
192192
services-http
193-
services-huggingface
193+
services-hf
194194
services-ipfs
195195
services-ipmfs
196196
services-memcached

bindings/java/Cargo.toml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ services-all = [
6363
# FIXME how to support HDFS services in bindings?
6464
# "services-hdfs",
6565
# "services-hdfs-native",
66-
"services-huggingface",
66+
"services-hf",
6767
"services-ipfs",
6868
"services-memcached",
6969
"services-mini-moka",
@@ -117,8 +117,9 @@ services-github = ["opendal/services-github"]
117117
services-gridfs = ["opendal/services-gridfs"]
118118
services-hdfs = ["opendal/services-hdfs"]
119119
services-hdfs-native = ["opendal/services-hdfs-native"]
120+
services-hf = ["opendal/services-hf"]
120121
services-http = ["opendal/services-http"]
121-
services-huggingface = ["opendal/services-huggingface"]
122+
services-huggingface = ["services-hf"]
122123
services-ipfs = ["opendal/services-ipfs"]
123124
services-ipmfs = ["opendal/services-ipmfs"]
124125
services-koofr = ["opendal/services-koofr"]

bindings/java/src/utility.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -92,8 +92,8 @@ fn intern_load_enabled_services(env: &mut JNIEnv) -> Result<jobjectArray> {
9292
opendal::services::HDFS_NATIVE_SCHEME,
9393
#[cfg(feature = "services-http")]
9494
opendal::services::HTTP_SCHEME,
95-
#[cfg(feature = "services-huggingface")]
96-
opendal::services::HUGGINGFACE_SCHEME,
95+
#[cfg(feature = "services-hf")]
96+
opendal::services::HF_SCHEME,
9797
#[cfg(feature = "services-ipfs")]
9898
opendal::services::IPFS_SCHEME,
9999
#[cfg(feature = "services-ipmfs")]

bindings/nodejs/Cargo.toml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ services-all = [
6161
# FIXME how to support HDFS services in bindings?
6262
# "services-hdfs",
6363
# "services-hdfs-native",
64-
"services-huggingface",
64+
"services-hf",
6565
"services-ipfs",
6666
"services-memcached",
6767
"services-mini-moka",
@@ -121,7 +121,8 @@ services-gdrive = ["opendal/services-gdrive"]
121121
services-gridfs = ["opendal/services-gridfs"]
122122
services-hdfs = ["opendal/services-hdfs"]
123123
services-hdfs-native = ["opendal/services-hdfs-native"]
124-
services-huggingface = ["opendal/services-huggingface"]
124+
services-hf = ["opendal/services-hf"]
125+
services-huggingface = ["services-hf"]
125126
services-ipfs = ["opendal/services-ipfs"]
126127
services-koofr = ["opendal/services-koofr"]
127128
services-memcached = ["opendal/services-memcached"]

bindings/python/Cargo.toml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ services-all = [
6060
'services-ftp',
6161
'services-gdrive',
6262
'services-gridfs',
63-
'services-huggingface',
63+
'services-hf',
6464
'services-ipfs',
6565
'services-koofr',
6666
'services-memcached',
@@ -122,8 +122,9 @@ services-hdfs = [
122122
"opendal/services-hdfs",
123123
] # FIXME EXCLUDED: how to support HDFS services in bindings?
124124
services-hdfs-native = ["opendal/services-hdfs-native"]
125+
services-hf = ["opendal/services-hf"]
125126
services-http = ["opendal/services-http"]
126-
services-huggingface = ["opendal/services-huggingface"]
127+
services-huggingface = ["services-hf"]
127128
services-ipfs = ["opendal/services-ipfs"]
128129
services-ipmfs = ["opendal/services-ipmfs"]
129130
services-koofr = ["opendal/services-koofr"]

bindings/python/src/services.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ pub enum PyScheme {
9898
HdfsNative,
9999
#[cfg(feature = "services-http")]
100100
Http,
101-
#[cfg(feature = "services-huggingface")]
101+
#[cfg(feature = "services-hf")]
102102
Hf,
103103
#[cfg(feature = "services-ipfs")]
104104
Ipfs,
@@ -4884,7 +4884,7 @@ impl_enum_to_str!(
48844884
HdfsNative => "hdfs-native",
48854885
#[cfg(feature = "services-http")]
48864886
Http => "http",
4887-
#[cfg(feature = "services-huggingface")]
4887+
#[cfg(feature = "services-hf")]
48884888
Hf => "hf",
48894889
#[cfg(feature = "services-ipfs")]
48904890
Ipfs => "ipfs",

core/Cargo.lock

Lines changed: 7 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

core/Cargo.toml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -143,8 +143,9 @@ services-github = ["dep:opendal-service-github"]
143143
services-gridfs = ["dep:opendal-service-gridfs"]
144144
services-hdfs = ["dep:opendal-service-hdfs"]
145145
services-hdfs-native = ["dep:opendal-service-hdfs-native"]
146+
services-hf = ["dep:opendal-service-hf"]
146147
services-http = ["dep:opendal-service-http"]
147-
services-huggingface = ["dep:opendal-service-huggingface"]
148+
services-huggingface = ["services-hf"]
148149
services-ipfs = ["dep:opendal-service-ipfs"]
149150
services-ipmfs = ["dep:opendal-service-ipmfs"]
150151
services-koofr = ["dep:opendal-service-koofr"]
@@ -257,8 +258,8 @@ opendal-service-github = { path = "services/github", version = "0.55.0", optiona
257258
opendal-service-gridfs = { path = "services/gridfs", version = "0.55.0", optional = true, default-features = false }
258259
opendal-service-hdfs = { path = "services/hdfs", version = "0.55.0", optional = true, default-features = false }
259260
opendal-service-hdfs-native = { path = "services/hdfs-native", version = "0.55.0", optional = true, default-features = false }
261+
opendal-service-hf = { path = "services/hf", version = "0.55.0", optional = true, default-features = false }
260262
opendal-service-http = { path = "services/http", version = "0.55.0", optional = true, default-features = false }
261-
opendal-service-huggingface = { path = "services/huggingface", version = "0.55.0", optional = true, default-features = false }
262263
opendal-service-ipfs = { path = "services/ipfs", version = "0.55.0", optional = true, default-features = false }
263264
opendal-service-ipmfs = { path = "services/ipmfs", version = "0.55.0", optional = true, default-features = false }
264265
opendal-service-koofr = { path = "services/koofr", version = "0.55.0", optional = true, default-features = false }

core/fuzz/Cargo.toml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,8 +49,9 @@ services-gdrive = ["opendal/services-gdrive"]
4949
services-ghac = ["opendal/services-ghac"]
5050
services-gridfs = ["opendal/services-gridfs"]
5151
services-hdfs = ["opendal/services-hdfs"]
52+
services-hf = ["opendal/services-hf"]
5253
services-http = ["opendal/services-http"]
53-
services-huggingface = ["opendal/services-huggingface"]
54+
services-huggingface = ["services-hf"]
5455
services-ipfs = ["opendal/services-ipfs"]
5556
services-ipmfs = ["opendal/services-ipmfs"]
5657
services-memcached = ["opendal/services-memcached"]
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,8 @@
1616
# under the License.
1717

1818
[package]
19-
description = "Apache OpenDAL huggingface service implementation"
20-
name = "opendal-service-huggingface"
19+
description = "Apache OpenDAL Hugging Face service implementation"
20+
name = "opendal-service-hf"
2121

2222
authors = { workspace = true }
2323
edition = { workspace = true }

0 commit comments

Comments
 (0)