Skip to content

Commit 1700b9f

Browse files
committed
OPENNLP-1753: Switch to Models v1.3 (OpenNLP 2.x)
- adds missing newly supported lang codes to DownloadUtil's internal map - adds missing newly supported lang codes to AbstractModelLoaderTest classes
1 parent 9ad1d6d commit 1700b9f

File tree

3 files changed

+13
-5
lines changed

3 files changed

+13
-5
lines changed

opennlp-tools/src/main/java/opennlp/tools/util/DownloadUtil.java

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -273,6 +273,8 @@ private Map<String, Map<ModelType, String>> toMap(List<String> links) {
273273
addModel("nl", link, result);
274274
} else if (link.contains("fr-ud")) { // French
275275
addModel("fr", link, result);
276+
} else if (link.contains("af-ud")) { // Afrikaans
277+
addModel("af", link, result);
276278
} else if (link.contains("bg-ud")) { // Bulgarian
277279
addModel("bg", link, result);
278280
} else if (link.contains("ca-ud")) { // Catalan
@@ -291,12 +293,18 @@ private Map<String, Map<ModelType, String>> toMap(List<String> links) {
291293
addModel("et", link, result);
292294
} else if (link.contains("eu-ud")) { // Basque
293295
addModel("eu", link, result);
296+
} else if (link.contains("fa-ud")) { // Persian
297+
addModel("fa", link, result);
294298
} else if (link.contains("fi-ud")) { // Finnish
295299
addModel("fi", link, result);
300+
} else if (link.contains("ga-ud")) { // Irish
301+
addModel("ga", link, result);
296302
} else if (link.contains("hy-ud")) { // Armenian
297303
addModel("hy", link, result);
298304
} else if (link.contains("is-ud")) { // Icelandic
299305
addModel("is", link, result);
306+
} else if (link.contains("id-ud")) { // Indonesian
307+
addModel("id", link, result);
300308
} else if (link.contains("ka-ud")) { // Georgian
301309
addModel("ka", link, result);
302310
} else if (link.contains("kk-ud")) { // Kazakh

opennlp-tools/src/test/java/opennlp/tools/AbstractModelLoaderTest.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -41,10 +41,10 @@ public abstract class AbstractModelLoaderTest {
4141
protected static final String VER = "1.3-2.5.4";
4242
protected static final String BIN = ".bin";
4343
protected static List<String> SUPPORTED_LANG_CODES = List.of(
44-
"en", "fr", "de", "it", "nl", "bg", "ca", "cs", "da", "el",
45-
"es", "et", "eu", "fi", "hr", "hy", "is", "ka", "kk", "ko",
46-
"lv", "no", "pl", "pt", "ro", "ru", "sk", "sl", "sr", "sv",
47-
"tr", "uk");
44+
"af", "en", "fr", "de", "it", "nl", "bg", "ca", "cs", "da", "el",
45+
"es", "et", "eu", "fa", "fi", "ga", "hr", "hy", "id", "is", "ka",
46+
"kk", "ko", "lv", "no", "pl", "pt", "ro", "ru", "sk", "sl", "sr",
47+
"sv", "tr", "uk");
4848

4949
protected static void downloadVersion15Model(String modelName) throws IOException {
5050
downloadModel(new URL(BASE_URL_MODELS_V15 + modelName));

opennlp-tools/src/test/java/opennlp/tools/util/DownloadParserTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ void testAvailableModels(String language, Map<ModelType, String> expectedModels)
4747
Map<String, Map<ModelType, String>> result = downloadParser.getAvailableModels();
4848

4949
assertNotNull(result);
50-
assertEquals(32, result.size());
50+
assertEquals(36, result.size());
5151

5252
final Map<ModelType, String> availableModels = result.get(language);
5353
assertNotNull(availableModels);

0 commit comments

Comments
 (0)