OPENNLP-1708: Introduce new OpenNLP module structure

- defines new Maven module hierarchy
- resolves OPENNLP-1709 (API)
- resolves OPENNLP-1710 (Core)
- resolves OPENNLP-1711 (CLI)
- resolves OPENNLP-1712 (Tools)
- resolves OPENNLP-1713 (Extensions)
- resolves OPENNLP-1717 (API in core/dl)
- resolves OPENNLP-1718 (API, RT, etc. in uima & morfologik)

Note: tests separated, all passing!

Author: mawiesne

opennlp-api/pom.xml

@@ -0,0 +1,44 @@
+<?xml version="1.0" encoding="UTF-8"?>
+
+<!--
+   Licensed to the Apache Software Foundation (ASF) under one
+   or more contributor license agreements.  See the NOTICE file
+   distributed with this work for additional information
+   regarding copyright ownership.  The ASF licenses this file
+   to you under the Apache License, Version 2.0 (the
+   "License"); you may not use this file except in compliance
+   with the License.  You may obtain a copy of the License at
+
+     http://www.apache.org/licenses/LICENSE-2.0
+
+   Unless required by applicable law or agreed to in writing,
+   software distributed under the License is distributed on an
+   "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+   KIND, either express or implied.  See the License for the
+   specific language governing permissions and limitations
+   under the License.
+-->
+
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+  <modelVersion>4.0.0</modelVersion>
+  <parent>
+    <groupId>org.apache.opennlp</groupId>
+    <artifactId>opennlp</artifactId>
+    <version>3.0.0-SNAPSHOT</version>
+  </parent>
+
+  <artifactId>opennlp-api</artifactId>
+  <packaging>jar</packaging>
+  <name>Apache OpenNLP API</name>
+
+  <dependencies>
+    <!-- External dependencies -->
+    <dependency>
+      <groupId>org.slf4j</groupId>
+      <artifactId>slf4j-api</artifactId>
+    </dependency>
+  </dependencies>
+  
+</project>

…a/opennlp/tools/chunker/ChunkSample.java …a/opennlp/tools/chunker/ChunkSample.javaopennlp-tools/src/main/java/opennlp/tools/chunker/ChunkSample.java renamed to opennlp-api/src/main/java/opennlp/tools/chunker/ChunkSample.java opennlp-tools/src/main/java/opennlp/tools/chunker/ChunkSample.java renamed to opennlp-api/src/main/java/opennlp/tools/chunker/ChunkSample.java

@@ -228,7 +228,7 @@ public static <T> String createUsage(Class<T> argProxyInterface) {
 
   /**
    * Auxiliary record that holds information about an argument. This is used by the
-   * {@link GenerateManualTool}, which creates a Docbook for the CLI automatically.
+   * {@code GenerateManualTool}, which creates a Docbook for the CLI automatically.
    */
   record Argument(String argument, String value, String description, boolean optional) {
 
@@ -331,10 +331,10 @@ public static String createUsage(Class<?>... argProxyInterfaces) {
       }
     }
 
-    if (usage.length() > 0)
+    if (!usage.isEmpty())
       usage.setLength(usage.length() - 1);
 
-    if (details.length() > 0) {
+    if (!details.isEmpty()) {
       details.setLength(details.length() - 1);
       usage.append("\n\nArguments description:\n").append(details);
     }
@@ -398,8 +398,8 @@ public static String validateArgumentsLoudly(String[] args, Class<?>... argProxy
     for (Class<?> argProxyInterface : argProxyInterfaces) {
       for (Method method : argProxyInterface.getMethods()) {
         String paramName = methodNameToParameter(method.getName());
-        int paramIndex = CmdLineUtil.getParameterIndex(paramName, args);
-        String valueString = CmdLineUtil.getParameter(paramName, args);
+        int paramIndex = getParameterIndex(paramName, args);
+        String valueString = getParameter(paramName, args);
         if (valueString == null) {
           OptionalParameter optionalParam = method.getAnnotation(OptionalParameter.class);
 
@@ -456,7 +456,7 @@ public static <T> T parse(String[] args, Class<T> argProxyInterface) {
     for (Method method : argProxyInterface.getMethods()) {
 
       String parameterName = methodNameToParameter(method.getName());
-      String valueString = CmdLineUtil.getParameter(parameterName, args);
+      String valueString = getParameter(parameterName, args);
 
       if (valueString == null) {
         OptionalParameter optionalParam = method.getAnnotation(OptionalParameter.class);
@@ -503,10 +503,10 @@ public static <T> String[] filter(String[] args, Class<T> argProxyInterface) {
     for (Method method : argProxyInterface.getMethods()) {
 
       String parameterName = methodNameToParameter(method.getName());
-      int idx = CmdLineUtil.getParameterIndex(parameterName, args);
+      int idx = getParameterIndex(parameterName, args);
       if (-1 < idx) {
         parameters.add(parameterName);
-        String valueString = CmdLineUtil.getParameter(parameterName, args);
+        String valueString = getParameter(parameterName, args);
         if (null != valueString) {
           parameters.add(valueString);
         }
@@ -515,4 +515,61 @@ public static <T> String[] filter(String[] args, Class<T> argProxyInterface) {
 
     return parameters.toArray(new String[0]);
   }
+
+  /**
+   * Retrieves the specified parameter from the specified arguments.
+   *
+   * @param param parameter name
+   * @param args arguments
+   * @return parameter value
+   */
+  private static Integer getIntParameter(String param, String[] args) {
+    String value = getParameter(param, args);
+
+    try {
+      if (value != null)
+        return Integer.parseInt(value);
+    }
+    catch (NumberFormatException ignored) {
+      // in this case return null
+    }
+
+    return null;
+  }
+
+  /**
+   * Retrieves the specified parameter from the given arguments.
+   *
+   * @param param parameter name
+   * @param args arguments
+   * @return parameter value
+   */
+  private static String getParameter(String param, String[] args) {
+    int i = getParameterIndex(param, args);
+    if (-1 < i) {
+      i++;
+      if (i < args.length) {
+        return args[i];
+      }
+    }
+
+    return null;
+  }
+
+  /**
+   * Returns the index of the parameter in the arguments, or {@code -1} if the parameter is not found.
+   *
+   * @param param parameter name
+   * @param args arguments
+   * @return the index of the parameter in the arguments, or {@code -1} if the parameter is not found
+   */
+  private static int getParameterIndex(String param, String[] args) {
+    for (int i = 0; i < args.length; i++) {
+      if (args[i].startsWith("-") && args[i].equals(param)) {
+        return i;
+      }
+    }
+
+    return -1;
+  }
 }