Skip to content

Commit 5c36ed8

Browse files
Merge pull request #39 from d4rkstar/issue_89
feat(operator): parameters to set the max. num. of users/roles/databases
2 parents 744096f + 52cae7c commit 5c36ed8

File tree

3 files changed

+31
-10
lines changed

3 files changed

+31
-10
lines changed

deploy/nuvolaris-permissions/whisk-crd.yaml

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -734,6 +734,23 @@ spec:
734734
replicas:
735735
description: number of total milvus replicas. Defaulted to 1
736736
type: integer
737+
proxy:
738+
description: MILVUS proxy related params
739+
type: object
740+
properties:
741+
max-role-num:
742+
description: Modify the Milvus maximum role limit
743+
type: integer
744+
max-user-num:
745+
description: Modify the Milvus maximum user limit
746+
type: integer
747+
root-coord:
748+
description: MILVUS rootCoord related params
749+
type: object
750+
properties:
751+
max-database-num:
752+
description: Modify the Milvus maximum database number
753+
type: integer
737754
password:
738755
description: MILVUS related user passwords
739756
type: object

nuvolaris/templates/milvus-cfg-base.yaml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -79,12 +79,13 @@ data:
7979
address: localhost
8080
port: 53100
8181
enableActiveStandby: false # Enable rootcoord active-standby
82+
maxDatabaseNum: {{milvus_max_database_num}}
8283
8384
proxy:
8485
port: 19530
8586
internalPort: 19529
86-
maxRoleNum: 100
87-
maxUserNum: 100
87+
maxRoleNum: {{milvus_max_role_num}}
88+
maxUserNum: {{milvus_max_user_num}}
8889
8990
queryCoord:
9091
address: localhost

nuvolaris/util.py

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -717,22 +717,25 @@ def get_milvus_config_data():
717717
data = {
718718
'milvus_etcd_username': "etcdmilvus",
719719
'milvus_etcd_password': cfg.get('milvus.password.etcd') or "0therPa55",
720-
"milvus_etcd_root_password":cfg.get("etcd.root.password") or "s0meP@ass3wd",
721-
'milvus_etcd_prefix': "milvus",
722-
'milvus_s3_username': "miniomilvus",
720+
'milvus_etcd_root_password':cfg.get("etcd.root.password") or "s0meP@ass3wd",
721+
'milvus_etcd_prefix': 'milvus',
722+
'milvus_s3_username': 'miniomilvus',
723723
'milvus_s3_password': cfg.get('milvus.password.s3') or "s0meP@ass3",
724-
'milvus_bucket_name': "vectors",
725-
'milvus_bucket_prefix': "milvus/nuvolaris-milvus",
724+
'milvus_bucket_name': 'vectors',
725+
'milvus_bucket_prefix': 'milvus/nuvolaris-milvus',
726726
'size': cfg.get('milvus.volume-size.cluster') or 10,
727727
'zookeeper_size': cfg.get('milvus.volume-size.zookeeper') or 10,
728728
'bookie_journal_size': cfg.get('milvus.volume-size.journal') or 25,
729729
'bookie_ledgers_size': cfg.get('milvus.volume-size.ledgers') or 50,
730730
'replicas': cfg.get('milvus.replicas') or 1,
731731
'storageClass': cfg.get('nuvolaris.storageclass'),
732-
"etcd_replicas":get_etcd_replica(),
733-
"etcd_container": "nuvolaris-etcd",
732+
'etcd_replicas':get_etcd_replica(),
733+
'etcd_container': 'nuvolaris-etcd',
734734
'milvus_root_password': cfg.get('milvus.password.root') or "An0therPa55",
735-
'nuvolaris_password': cfg.get('milvus.nuvolaris.password') or "Nuv0therPa55"
735+
'nuvolaris_password': cfg.get('milvus.nuvolaris.password') or "Nuv0therPa55",
736+
'milvus_max_role_num': cfg.get('milvus.proxy.max-role-num') or 10,
737+
'milvus_max_user_num': cfg.get('milvus.proxy.max-user-num') or 100,
738+
'milvus_max_database_num': cfg.get('milvus.root-coord.max-database-num') or 64
736739
}
737740

738741
data["etcd_range"]=range(data["etcd_replicas"])

0 commit comments

Comments
 (0)