Add jmx options

Author: upgle

helm/openwhisk/templates/_helpers.tpl

@@ -292,7 +292,6 @@ imagePullSecrets:
 {{/* Environment variables required for invoker volumes configuration */}}
 {{- define "openwhisk.invoker.volumes" -}}
 {{- if eq .Values.invoker.containerFactory.impl "docker" }}
-      volumes:
 {{ include "openwhisk.docker_volumes" . | indent 6 }}
       - name: scripts-dir
         configMap:
@@ -303,7 +302,6 @@ imagePullSecrets:
 {{/* Environment variables required for invoker volumes configuration */}}
 {{- define "openwhisk.invoker.volume_mounts" -}}
 {{- if (eq .Values.invoker.containerFactory.impl "docker") }}
-        volumeMounts:
 {{ include "openwhisk.docker_volume_mounts" . | indent 8 }}
 {{- if .Values.invoker.containerFactory.networkConfig.dns.inheritInvokerConfig }}
         - name: scripts-dir

helm/openwhisk/templates/controller-pod.yaml

@@ -63,9 +63,13 @@ spec:
 {{- end }}
 {{ include "openwhisk.readiness.waitForCouchDB" . | indent 6 }}
 {{- if eq .Values.activationStoreBackend "ElasticSearch" }}
-      # The controller must wait for elasticsearch to be ready before it starts
+# The controller must wait for elasticsearch to be ready before it starts
 {{ include "openwhisk.readiness.waitForElasticSearch" . | indent 6 }}
 {{- end }}
+      volumes:
+      - name: jmxremote-secret
+        secret:
+          secretName: {{ .Release.Name }}-jmxremote-secret
       # The lean controller requires invoker volumes mounts
 {{- if .Values.controller.lean }}
 {{ include "openwhisk.invoker.volumes" . }}
@@ -84,10 +88,21 @@ spec:
         ports:
         - name: controller
           containerPort: {{ .Values.controller.port }}
+        - name: jmx
+          jmxPort: {{ .Values.jmx.port }}
+        - name: jmx-rmi
+          jmxPort: {{ .Values.jmx.rmiPort }}
         - name: akka-remoting
           containerPort: 2552
         - name: akka-mgmt-http
           containerPort: 19999
+        volumeMounts:
+        - name: jmxremote-secret
+          mountPath: "/conf/jmxremote.access"
+          subPath: "jmxremote.access"
+        - name: jmxremote-secret
+          mountPath: "/conf/jmxremote.password"
+          subPath: "jmxremote.password"
 {{- if .Values.controller.lean }}
 {{ include "openwhisk.invoker.volume_mounts" . }}
 {{- end }}
@@ -127,7 +142,7 @@ spec:
 
         # Java options
         - name: "JAVA_OPTS"
-          value: "-Xmx{{- .Values.controller.jvmHeapMB -}}M {{ .Values.controller.jvmOptions }}"
+          value: "-Xmx{{- .Values.controller.jvmHeapMB -}}M {{ .Values.controller.jvmOptions }} {{ if .Values.jmx.enabled }} {{ .Values.jmx.jvmCommonArgs }} -Dcom.sun.management.jmxremote.rmi.port={{ .Values.jmx.rmiPort }} -Dcom.sun.management.jmxremote.port={{ .Values.jmx.port }} {{ end }}"
 
         # specific controller arguments
         - name: "CONTROLLER_OPTS"

helm/openwhisk/templates/invoker-pod.yaml

@@ -68,7 +68,10 @@ spec:
       tolerations:
 {{ include "openwhisk.toleration.invoker" . | indent 8 }}
 {{- end }}
-
+      volumes:
+      - name: jmxremote-secret
+        secret:
+          secretName: {{ .Release.Name }}-jmxremote-secret
 {{ include "openwhisk.invoker.volumes" . }}
 
       initContainers:
@@ -138,7 +141,7 @@ spec:
 
           # Java options
           - name: "JAVA_OPTS"
-            value: "-Xmx{{- .Values.invoker.jvmHeapMB -}}M {{ .Values.invoker.jvmOptions }}"
+            value: "-Xmx{{- .Values.invoker.jvmHeapMB -}}M {{ .Values.invoker.jvmOptions }} {{ if .Values.jmx.enabled }} {{ .Values.jmx.jvmCommonArgs }} -Dcom.sun.management.jmxremote.rmi.port={{ .Values.jmx.rmiPort }} -Dcom.sun.management.jmxremote.port={{ .Values.jmx.port }} {{ end }}"
 
           # Invoker options
           - name: "INVOKER_OPTS"
@@ -214,5 +217,16 @@ spec:
         ports:
         - name: invoker
           containerPort: {{ .Values.invoker.port }}
+        - name: jmx
+          jmxPort: {{ .Values.jmx.port }}
+        - name: jmx-rmi
+          jmxPort: {{ .Values.jmx.rmiPort }}
+        volumeMounts:
+        - name: jmxremote-secret
+          mountPath: "/conf/jmxremote.access"
+          subPath: "jmxremote.access"
+        - name: jmxremote-secret
+          mountPath: "/conf/jmxremote.password"
+          subPath: "jmxremote.password"
 {{ include "openwhisk.invoker.volume_mounts" . }}
 {{- end }}

helm/openwhisk/templates/jmx-remote-secret.yaml

@@ -0,0 +1,27 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+apiVersion: v1
+kind: Secret
+metadata:
+  name: {{ .Release.Name }}-jmxremote-secret
+  labels:
+{{ include "openwhisk.label_boilerplate" . | indent 4 }}
+type: Opaque
+data:
+  jmxremote.access: {{ (printf "%s %s" .Values.jmx.user "readwrite") | b64enc }}
+  jmxremote.password: {{ (printf "%s %s" .Values.jmx.user .Values.jmx.pass) | b64enc }}

helm/openwhisk/values.yaml

@@ -289,6 +289,15 @@ invoker:
       isolateUserActions: true
       replicaCount: 1
 
+# JMX configurations
+jmx:
+  enabled: false
+  port: 15000
+  rmiPort: 16000
+  user: "jmxuser"
+  pass: "jmxpass"
+  jvmCommonArgs: "-Dcom.sun.management.jmxremote -Dcom.sun.management.jmxremote.ssl=false -Dcom.sun.management.jmxremote.local.only=false -Dcom.sun.management.jmxremote.authenticate=true -Dcom.sun.management.jmxremote.password.file=/home/owuser/jmxremote.password -Dcom.sun.management.jmxremote.access.file=/home/owuser/jmxremote.access"
+
 # API Gateway configurations
 apigw:
   imageName: "openwhisk/apigateway"