Skip to content

Commit c020fe6

Browse files
dongjoon-hyunwilliamhyun
authored andcommitted
ORC-1819: [FOLLOWUP] Fix baseurl parameter and more links
### What changes were proposed in this pull request? This is a follow-up to fix `baseurl` parameter and more links. - #2095 ### Why are the changes needed? `baseurl` option is defined like the following. - https://jekyllrb.com/docs/configuration/options/ > Base URL: Serve the website from the given base URL (the path between web-server or domain root and your landing page). This only updates https://apache.github.io/orc/ while keeping https://orc.apache.org unchanged. ### How was this patch tested? Manual review. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #2099 from dongjoon-hyun/links. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: William Hyun <william@apache.org>
1 parent 86b6926 commit c020fe6

File tree

4 files changed

+5
-5
lines changed

4 files changed

+5
-5
lines changed

.github/workflows/pages.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ jobs:
6060
gem install bundler -n /usr/local/bin
6161
bundle install --retry=100
6262
git clone https://github.com/apache/orc.git -b asf-site target
63-
bundle exec jekyll build -b https://apache.github.io/orc
63+
bundle exec jekyll build -b /orc
6464
- name: Setup Pages
6565
uses: actions/configure-pages@v5
6666
- name: Upload artifact

site/_includes/docs_ul.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212

1313
{% for p in site.docs %}
1414
{% if p.url == item_url %}
15-
<li class="{{ c }}"><a href="{{ p.url }}">{{ p.title }}</a></li>
15+
<li class="{{ c }}"><a href="{{ site.baseurl }}{{ p.url }}">{{ p.title }}</a></li>
1616
{% break %}
1717
{% endif %}
1818
{% endfor %}

site/_includes/header.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
<div class="grid">
66
<div class="unit one-quarter center-on-mobiles">
77
<h1>
8-
<a href="/">
8+
<a href="{{ site.baseurl }}/">
99
<span class="sr-only">Apache ORC</span>
1010
<img src="{{ site.baseurl }}/img/logo.png" width="249" height="101" alt="ORC Logo">
1111
</a>

site/_includes/news_contents.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ <h4>Recent Releases</h4>
1212
<ul>
1313
{% for post in site.categories.release limit:5 %}
1414
<li class="{% if page.title == post.title %}current{% endif %}">
15-
<a href="{{ post.url }}">Version {{ post.version }}</a>
15+
<a href="{{ site.baseurl }}{{ post.url }}">Version {{ post.version }}</a>
1616
</li>
1717
{% endfor %}
1818
</ul>
@@ -21,7 +21,7 @@ <h4>Other News</h4>
2121
{% for post in site.posts %}
2222
{% unless post.categories contains 'release' %}
2323
<li class="{% if page.title == post.title %}current{% endif %}">
24-
<a href="{{ post.url }}">{{ post.title }}</a>
24+
<a href="{{ site.baseurl }}{{ post.url }}">{{ post.title }}</a>
2525
</li>
2626
{% endunless %}
2727
{% endfor %}

0 commit comments

Comments
 (0)