Skip to content

Comments

HDDS-14003. EventNotification: Added protobufs and entity class#9363

Open
gardenia wants to merge 460 commits intoapache:HDDS-13513_Event_Notification_FeatureBranchfrom
gardenia:HDDS-14003
Open

HDDS-14003. EventNotification: Added protobufs and entity class#9363
gardenia wants to merge 460 commits intoapache:HDDS-13513_Event_Notification_FeatureBranchfrom
gardenia:HDDS-14003

Conversation

@gardenia
Copy link

Please describe your PR in detail:

In OzoneManagerStateMachine when certain write requests complete successfully a summary of that request will be written to a new rocksdb "ledger" table named CompletedRequestInfo

The current CompletedRequestInfo schema is minimal:

/**
 * CompletedRequestInfo table entry
 */
message CompletedRequestInfo {

  optional int64 trxLogIndex = 1;
  required Type cmdType = 2; // Type of the command
  optional string volumeName = 3;
  optional string bucketName = 4;
  optional string keyName = 5;
  optional uint64 creationTime = 6;

  optional CreateKeyOperationArgs       createKeyArgs = 7;
  optional RenameKeyOperationArgs       renameKeyArgs = 8;
  optional DeleteKeyOperationArgs       deleteKeyArgs = 9;
  optional CommitKeyOperationArgs       commitKeyArgs = 10;
  optional CreateDirectoryOperationArgs createDirectoryArgs = 11;
  optional CreateFileOperationArgs      createFileArgs = 12;
}

The use of "optional" for the arguments was based on feedback from the community call where @errose28 made the point that the previous sketch of a schema (using a freeform Map<String, String>) did not jibe well with schema management and this optional pattern had been used in other places to get around that.

This change adds the protobufs and entity class to store the completed event info (with the intent that a consumer can use that data to generate event notifications about changes on the filesystem)

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-14003

How was this patch tested?

unit tests

@gardenia gardenia changed the title HDDS-14003. EventNotification: Added protobufs and entity class for storing the ledger of completed events HDDS-14003. EventNotification: Added protobufs and entity class Nov 25, 2025
navinko and others added 23 commits December 13, 2025 07:55
smengcl and others added 24 commits February 17, 2026 22:09
Generated-by: GitHub Copilot with Claude Opus 4.6
@gardenia gardenia force-pushed the HDDS-14003 branch 2 times, most recently from a5af92a to dda1383 Compare February 23, 2026 12:46
@gardenia
Copy link
Author

Hi @gardenia , can you check the failed UT TestOmMetadataManager? looks related.

Hi @gardenia , can you check the failed UT TestOmMetadataManager? looks related.

@ChenSammi Fixed. Thx

@gardenia
Copy link
Author

@gardenia , I would recommend to merge master into HDDS-13513_Event_Notification_FeatureBranch after this patch. HDDS-13513_Event_Notification_FeatureBranch is three month behind master.

@gardenia , I would recommend to merge master into HDDS-13513_Event_Notification_FeatureBranch after this patch. HDDS-13513_Event_Notification_FeatureBranch is three month behind master.

@ChenSammi I have rebased it against upstream/master but now the PR has diverged a lot from the feature branch that was set up for this work HDDS-13513_Event_Notification_FeatureBranch

Would you be able to rebase HDDS-13513_Event_Notification_FeatureBranch against upstream master so I can rebase my PR against HDDS-13513_Event_Notification_FeatureBranch again and see only my changes? I'm not sure I have permission for this.

Let me know if there is some different procedure for this I might be missing.

cc: @errose28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.