HDDS-14683. Remove redundant FileSystem field from test classes#9797
Merged
adoroszlai merged 2 commits intoapache:masterfrom Feb 21, 2026
Merged
HDDS-14683. Remove redundant FileSystem field from test classes#9797adoroszlai merged 2 commits intoapache:masterfrom
adoroszlai merged 2 commits intoapache:masterfrom
Conversation
adoroszlai
reviewed
Feb 20, 2026
Contributor
adoroszlai
left a comment
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @len548 for the patch.
Comment on lines
158
to
159
| private OzoneManagerProtocol writeClient; | ||
| private FileSystem fs; | ||
| private OzoneFileSystem o3fs; |
Contributor
There was a problem hiding this comment.
Can we keep the name fs instead of o3fs and ofs, respectively? Not only does it reduce change for this patch (due to way more usage of fs vs. o3fs/ofs), it keeps the test code in the two classes more similar, which helps further refactoring.
private OzoneFileSystem fs;
adoroszlai
approved these changes
Feb 21, 2026
Contributor
|
Thanks @len548 for the patch, @yandrey321 for the review. |
Contributor
Author
|
Thanks for the reviews and merge, @adoroszlai and @yandrey321 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Removed redundant
private FileSystem fsfield fromAbstractOzoneFileSystemTestandAbstractRootedOzoneFileSystemTest. Both classes castfsto each type-specific filesystem instances (o3fsandofsrespectively) so all the usages offscan be done by those instances, making it unnecessary.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-14683
How was this patch tested?
The existing CI continues to pass: https://github.com/len548/ozone/actions/runs/22192506262