Skip to content

Commit 541ea26

Browse files
author
mingfeng
committed
fix fail tests
1 parent b8d9085 commit 541ea26

File tree

4 files changed

+17
-8
lines changed

4 files changed

+17
-8
lines changed

paimon-core/src/main/java/org/apache/paimon/manifest/PartitionEntry.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,10 @@ public long lastFileCreationTime() {
8181
return lastFileCreationTime;
8282
}
8383

84+
public int bucketCount() {
85+
return bucketCount;
86+
}
87+
8488
public PartitionEntry merge(PartitionEntry entry) {
8589
return new PartitionEntry(
8690
partition,

paimon-core/src/main/java/org/apache/paimon/operation/FileStoreCommitImpl.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1165,7 +1165,10 @@ private List<PartitionStatistics> toPartitionStatistics(
11651165
Map<BinaryRow, Integer> bucketCountMap = scanner.readBucketCounts(snapshot, partitions);
11661166
for (PartitionEntry entry : deltaStatistics) {
11671167
Integer bucketCount = bucketCountMap.get(entry.partition());
1168-
statistics.add(entry.toPartitionStatistics(partitionComputer, bucketCount));
1168+
statistics.add(
1169+
entry.toPartitionStatistics(
1170+
partitionComputer,
1171+
Optional.ofNullable(bucketCount).orElse(entry.bucketCount())));
11691172
}
11701173
} else {
11711174
for (PartitionEntry entry : deltaStatistics) {

paimon-core/src/test/java/org/apache/paimon/utils/PartitionStatisticsReporterTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@ public void close() {
135135
assertThat(partitionParams).containsKey("c1=a/");
136136
assertThat(partitionParams.get("c1=a/").toString())
137137
.isEqualTo(
138-
"{spec={c1=a}, recordCount=2, fileSizeInBytes=705, fileCount=1, lastFileCreationTime=1729598544974}");
138+
"{spec={c1=a}, recordCount=2, fileSizeInBytes=705, fileCount=1, lastFileCreationTime=1729598544974, bucketCount=0}");
139139
action.close();
140140
assertThat(closed).isTrue();
141141
}

paimon-flink/paimon-flink-common/src/test/java/org/apache/paimon/flink/RESTCatalogITCase.java

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
package org.apache.paimon.flink;
2020

2121
import org.apache.paimon.catalog.Identifier;
22+
import org.apache.paimon.partition.Partition;
2223
import org.apache.paimon.rest.RESTToken;
2324

2425
import org.apache.paimon.shade.guava30.com.google.common.collect.ImmutableList;
@@ -192,11 +193,12 @@ public void testBucketCountStatistics() throws Exception {
192193

193194
private void validateBucketCount(
194195
String databaseName, String tableName, Integer expectedBucketCount) throws Exception {
195-
Catalog catalog = tEnv.getCatalog(tEnv.getCurrentCatalog()).get();
196-
org.apache.paimon.catalog.Catalog paimonCatalog = ((FlinkCatalog) catalog).catalog();
197-
List<org.apache.paimon.partition.Partition> partitions =
198-
paimonCatalog.listPartitions(Identifier.create(databaseName, tableName));
199-
assertThat(partitions).isNotEmpty();
200-
assertThat(partitions.get(0).bucketCount()).isEqualTo(expectedBucketCount);
196+
Catalog flinkCatalog = tEnv.getCatalog(tEnv.getCurrentCatalog()).get();
197+
try (org.apache.paimon.catalog.Catalog catalog = ((FlinkCatalog) flinkCatalog).catalog()) {
198+
List<Partition> partitions =
199+
catalog.listPartitions(Identifier.create(databaseName, tableName));
200+
assertThat(partitions).isNotEmpty();
201+
assertThat(partitions.get(0).bucketCount()).isEqualTo(expectedBucketCount);
202+
}
201203
}
202204
}

0 commit comments

Comments
 (0)