[core] Correct bitmap types support in writer (#5309)

Author: JingsongLi

docs/content/concepts/spec/fileindex.md

@@ -261,34 +261,6 @@ Bitmap only support the following data type:
       <td><code>BooleanType</code></td>
       <td>true</td>
     </tr>
-    <tr>
-      <td><code>DecimalType(precision, scale)</code></td>
-      <td>false</td>
-    </tr>
-    <tr>
-      <td><code>FloatType</code></td>
-      <td>Not recommended</td>
-    </tr>
-    <tr>
-      <td><code>DoubleType</code></td>
-      <td>Not recommended</td>
-    </tr>
-    <tr>
-      <td><code>VarBinaryType</code>, <code>BinaryType</code></td>
-      <td>false</td>
-    </tr>
-    <tr>
-      <td><code>RowType</code></td>
-      <td>false</td>
-    </tr>
-    <tr>
-      <td><code>MapType</code></td>
-      <td>false</td>
-    </tr>
-    <tr>
-      <td><code>ArrayType</code></td>
-      <td>false</td>
-    </tr>
     </tbody>
 </table>
 
@@ -384,37 +356,5 @@ BSI only support the following data type:
       <td><code>DecimalType(precision, scale)</code></td>
       <td>true</td>
     </tr>
-    <tr>
-      <td><code>FloatType</code></td>
-      <td>false</td>
-    </tr>
-    <tr>
-      <td><code>DoubleType</code></td>
-      <td>false</td>
-    </tr>
-    <tr>
-      <td><code>String</code></td>
-      <td>false</td>
-    </tr>
-    <tr>
-      <td><code>VarBinaryType</code>, <code>BinaryType</code></td>
-      <td>false</td>
-    </tr>
-    <tr>
-      <td><code>RowType</code></td>
-      <td>false</td>
-    </tr>
-    <tr>
-      <td><code>MapType</code></td>
-      <td>false</td>
-    </tr>
-    <tr>
-      <td><code>ArrayType</code></td>
-      <td>false</td>
-    </tr>
-    <tr>
-      <td><code>BooleanType</code></td>
-      <td>false</td>
-    </tr>
     </tbody>
 </table>

paimon-common/src/main/java/org/apache/paimon/fileindex/FileIndexWriter.java

@@ -28,6 +28,7 @@ public void writeRecord(Object key) {
         write(key);
     }
 
+    /** The key object may be reused, if saved in memory, please be sure to manually copy it. */
     public abstract void write(Object key);
 
     public abstract byte[] serializedBytes();

paimon-common/src/main/java/org/apache/paimon/fileindex/bitmap/BitmapFileIndex.java

@@ -18,6 +18,7 @@
 
 package org.apache.paimon.fileindex.bitmap;
 
+import org.apache.paimon.data.BinaryString;
 import org.apache.paimon.data.Timestamp;
 import org.apache.paimon.fileindex.FileIndexReader;
 import org.apache.paimon.fileindex.FileIndexResult;
@@ -27,7 +28,6 @@
 import org.apache.paimon.options.Options;
 import org.apache.paimon.predicate.FieldRef;
 import org.apache.paimon.types.DataType;
-import org.apache.paimon.types.DataTypeDefaultVisitor;
 import org.apache.paimon.types.LocalZonedTimestampType;
 import org.apache.paimon.types.TimestampType;
 import org.apache.paimon.utils.RoaringBitmap32;
@@ -315,7 +315,53 @@ private void readInternalMeta(DataType dataType) {
     // Currently, it is mainly used to convert timestamps to long
     public static Function<Object, Object> getValueMapper(DataType dataType) {
         return dataType.accept(
-                new DataTypeDefaultVisitor<Function<Object, Object>>() {
+                new BitmapTypeVisitor<Function<Object, Object>>() {
+
+                    @Override
+                    public Function<Object, Object> visitBinaryString() {
+                        return o -> {
+                            if (o instanceof BinaryString) {
+                                return ((BinaryString) o).copy();
+                            }
+                            return o;
+                        };
+                    }
+
+                    @Override
+                    public Function<Object, Object> visitByte() {
+                        return Function.identity();
+                    }
+
+                    @Override
+                    public Function<Object, Object> visitShort() {
+                        return Function.identity();
+                    }
+
+                    @Override
+                    public Function<Object, Object> visitInt() {
+                        return Function.identity();
+                    }
+
+                    @Override
+                    public Function<Object, Object> visitLong() {
+                        return Function.identity();
+                    }
+
+                    @Override
+                    public Function<Object, Object> visitFloat() {
+                        return Function.identity();
+                    }
+
+                    @Override
+                    public Function<Object, Object> visitDouble() {
+                        return Function.identity();
+                    }
+
+                    @Override
+                    public Function<Object, Object> visitBoolean() {
+                        return Function.identity();
+                    }
+
                     @Override
                     public Function<Object, Object> visit(TimestampType timestampType) {
                         return getTimeStampMapper(timestampType.getPrecision());
@@ -327,11 +373,6 @@ public Function<Object, Object> visit(
                         return getTimeStampMapper(localZonedTimestampType.getPrecision());
                     }
 
-                    @Override
-                    protected Function<Object, Object> defaultMethod(DataType dataType) {
-                        return Function.identity();
-                    }
-
                     private Function<Object, Object> getTimeStampMapper(int precision) {
                         return o -> {
                             if (o == null) {