Skip to content

Commit f3333cd

Browse files
authored
[rest] Remove useless CreateDatabaseResponse (#5318)
1 parent 7975b40 commit f3333cd

File tree

6 files changed

+6
-47
lines changed

6 files changed

+6
-47
lines changed

paimon-core/src/main/java/org/apache/paimon/rest/RESTCatalog.java

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,6 @@
5555
import org.apache.paimon.rest.responses.AlterDatabaseResponse;
5656
import org.apache.paimon.rest.responses.CommitTableResponse;
5757
import org.apache.paimon.rest.responses.ConfigResponse;
58-
import org.apache.paimon.rest.responses.CreateDatabaseResponse;
5958
import org.apache.paimon.rest.responses.ErrorResponseResourceType;
6059
import org.apache.paimon.rest.responses.GetDatabaseResponse;
6160
import org.apache.paimon.rest.responses.GetTableResponse;
@@ -207,11 +206,7 @@ public void createDatabase(String name, boolean ignoreIfExists, Map<String, Stri
207206
checkNotSystemDatabase(name);
208207
CreateDatabaseRequest request = new CreateDatabaseRequest(name, properties);
209208
try {
210-
client.post(
211-
resourcePaths.databases(),
212-
request,
213-
CreateDatabaseResponse.class,
214-
restAuthFunction);
209+
client.post(resourcePaths.databases(), request, restAuthFunction);
215210
} catch (AlreadyExistsException e) {
216211
if (!ignoreIfExists) {
217212
throw new DatabaseAlreadyExistException(name);

paimon-core/src/test/java/org/apache/paimon/rest/MockRESTMessage.java

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@
2727
import org.apache.paimon.rest.requests.CreateViewRequest;
2828
import org.apache.paimon.rest.requests.RenameTableRequest;
2929
import org.apache.paimon.rest.responses.AlterDatabaseResponse;
30-
import org.apache.paimon.rest.responses.CreateDatabaseResponse;
3130
import org.apache.paimon.rest.responses.GetDatabaseResponse;
3231
import org.apache.paimon.rest.responses.GetTableResponse;
3332
import org.apache.paimon.rest.responses.GetTableTokenResponse;
@@ -72,12 +71,6 @@ public static CreateDatabaseRequest createDatabaseRequest(String name) {
7271
return new CreateDatabaseRequest(name, options);
7372
}
7473

75-
public static CreateDatabaseResponse createDatabaseResponse(String name) {
76-
Map<String, String> options = new HashMap<>();
77-
options.put("a", "b");
78-
return new CreateDatabaseResponse(name, options);
79-
}
80-
8174
public static GetDatabaseResponse getDatabaseResponse(String name) {
8275
Map<String, String> options = new HashMap<>();
8376
options.put("a", "b");

paimon-core/src/test/java/org/apache/paimon/rest/RESTCatalogServer.java

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,6 @@
5252
import org.apache.paimon.rest.responses.AlterDatabaseResponse;
5353
import org.apache.paimon.rest.responses.CommitTableResponse;
5454
import org.apache.paimon.rest.responses.ConfigResponse;
55-
import org.apache.paimon.rest.responses.CreateDatabaseResponse;
5655
import org.apache.paimon.rest.responses.ErrorResponse;
5756
import org.apache.paimon.rest.responses.ErrorResponseResourceType;
5857
import org.apache.paimon.rest.responses.GetDatabaseResponse;
@@ -571,7 +570,6 @@ private MockResponse commitTableHandle(Identifier identifier, String data) throw
571570

572571
private MockResponse databasesApiHandler(
573572
String method, String data, Map<String, String> parameters) throws Exception {
574-
RESTResponse response;
575573
switch (method) {
576574
case "GET":
577575
List<String> databases = new ArrayList<>(databaseStore.keySet());
@@ -586,8 +584,7 @@ private MockResponse databasesApiHandler(
586584
catalog.createDatabase(databaseName, false);
587585
databaseStore.put(
588586
databaseName, Database.of(databaseName, requestBody.getOptions(), null));
589-
response = new CreateDatabaseResponse(databaseName, requestBody.getOptions());
590-
return mockResponse(response, 200);
587+
return new MockResponse().setResponseCode(200);
591588
default:
592589
return new MockResponse().setResponseCode(404);
593590
}

paimon-core/src/test/java/org/apache/paimon/rest/RESTObjectMapperTest.java

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@
2626
import org.apache.paimon.rest.requests.RenameTableRequest;
2727
import org.apache.paimon.rest.responses.AlterDatabaseResponse;
2828
import org.apache.paimon.rest.responses.ConfigResponse;
29-
import org.apache.paimon.rest.responses.CreateDatabaseResponse;
3029
import org.apache.paimon.rest.responses.ErrorResponse;
3130
import org.apache.paimon.rest.responses.GetDatabaseResponse;
3231
import org.apache.paimon.rest.responses.GetTableResponse;
@@ -84,17 +83,6 @@ public void createDatabaseRequestParseTest() throws Exception {
8483
assertEquals(request.getOptions().size(), parseData.getOptions().size());
8584
}
8685

87-
@Test
88-
public void createDatabaseResponseParseTest() throws Exception {
89-
String name = MockRESTMessage.databaseName();
90-
CreateDatabaseResponse response = MockRESTMessage.createDatabaseResponse(name);
91-
String responseStr = OBJECT_MAPPER.writeValueAsString(response);
92-
CreateDatabaseResponse parseData =
93-
OBJECT_MAPPER.readValue(responseStr, CreateDatabaseResponse.class);
94-
assertEquals(name, parseData.getName());
95-
assertEquals(response.getOptions().size(), parseData.getOptions().size());
96-
}
97-
9886
@Test
9987
public void getDatabaseResponseParseTest() throws Exception {
10088
String name = MockRESTMessage.databaseName();

paimon-open-api/rest-catalog-open-api.yaml

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -234,11 +234,7 @@ paths:
234234
$ref: '#/components/schemas/CreateDatabaseRequest'
235235
responses:
236236
"200":
237-
description: OK
238-
content:
239-
application/json:
240-
schema:
241-
$ref: '#/components/schemas/CreateDatabaseResponse'
237+
description: Success, no content
242238
"409":
243239
description: Resource has exist
244240
content:
@@ -1430,8 +1426,6 @@ components:
14301426
format: int64
14311427
schema:
14321428
$ref: '#/components/schemas/Schema'
1433-
uuid:
1434-
type: string
14351429
owner:
14361430
type: string
14371431
createdAt:

paimon-open-api/src/main/java/org/apache/paimon/open/api/RESTCatalogController.java

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@
3232
import org.apache.paimon.rest.responses.AlterDatabaseResponse;
3333
import org.apache.paimon.rest.responses.CommitTableResponse;
3434
import org.apache.paimon.rest.responses.ConfigResponse;
35-
import org.apache.paimon.rest.responses.CreateDatabaseResponse;
3635
import org.apache.paimon.rest.responses.ErrorResponse;
3736
import org.apache.paimon.rest.responses.GetDatabaseResponse;
3837
import org.apache.paimon.rest.responses.GetTableResponse;
@@ -125,11 +124,7 @@ public ListDatabasesResponse listDatabases(
125124
summary = "Create Databases",
126125
tags = {"database"})
127126
@ApiResponses({
128-
@ApiResponse(
129-
responseCode = "200",
130-
content = {
131-
@Content(schema = @Schema(implementation = CreateDatabaseResponse.class))
132-
}),
127+
@ApiResponse(responseCode = "200", description = "Success, no content"),
133128
@ApiResponse(
134129
responseCode = "409",
135130
description = "Resource has exist",
@@ -139,11 +134,8 @@ public ListDatabasesResponse listDatabases(
139134
content = {@Content(schema = @Schema())})
140135
})
141136
@PostMapping("/v1/{prefix}/databases")
142-
public CreateDatabaseResponse createDatabases(
143-
@PathVariable String prefix, @RequestBody CreateDatabaseRequest request) {
144-
Map<String, String> properties = new HashMap<>();
145-
return new CreateDatabaseResponse("name", properties);
146-
}
137+
public void createDatabases(
138+
@PathVariable String prefix, @RequestBody CreateDatabaseRequest request) {}
147139

148140
@Operation(
149141
summary = "Get Database",

0 commit comments

Comments
 (0)