Skip to content

Commit 6a7207b

Browse files
committed
PARQUET-34: Simplify size#toString and include col name
1 parent 495d504 commit 6a7207b

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

parquet-column/src/main/java/org/apache/parquet/filter2/predicate/Operators.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -576,8 +576,8 @@ public int hashCode() {
576576

577577
@Override
578578
public String toString() {
579-
String name = Size.class.getSimpleName().toLowerCase(Locale.ENGLISH);
580-
return name + "(" + operator.toString().toLowerCase() + " " + value + ")";
579+
return "size(" + column.getColumnPath().toDotString() + " "
580+
+ operator.toString().toLowerCase() + " " + value + ")";
581581
}
582582
}
583583

parquet-column/src/test/java/org/apache/parquet/filter2/predicate/TestFilterApiMethods.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@
2929
import static org.apache.parquet.filter2.predicate.FilterApi.not;
3030
import static org.apache.parquet.filter2.predicate.FilterApi.notEq;
3131
import static org.apache.parquet.filter2.predicate.FilterApi.or;
32+
import static org.apache.parquet.filter2.predicate.FilterApi.size;
3233
import static org.apache.parquet.filter2.predicate.FilterApi.userDefined;
3334
import static org.apache.parquet.filter2.predicate.Operators.NotEq;
3435
import static org.junit.Assert.assertEquals;
@@ -139,6 +140,9 @@ public void testToString() {
139140
assertEquals(
140141
"or(contains(eq(a.string.column, Binary{\"foo\"})), and(contains(eq(a.string.column, Binary{\"bar\"})), not(contains(eq(a.string.column, Binary{\"baz\"})))))",
141142
pred.toString());
143+
144+
pred = size(binColumn, Operators.Size.Operator.GTE, 5);
145+
assertEquals("size(a.string.column gte 5)", pred.toString());
142146
}
143147

144148
@Test

0 commit comments

Comments
 (0)