PDFBOX-5660: optimize, as suggested by Valery Bokov; closes #279

THausherr · THausherr · commit 02fb6bededce · 2025-10-07T10:54:36.000Z
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1928994 13f79535-47bb-0310-9956-ffa450edef68
diff --git a/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDButton.java b/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDButton.java
@@ -293,9 +293,10 @@ void constructAppearances() throws IOException
                 continue;
             }
             PDAppearanceEntry appearanceEntry = appearance.getNormalAppearance();
-            if (appearanceEntry.getCOSObject().containsKey(getCOSObject().getCOSName(COSName.V)))
+            COSName value = getCOSObject().getCOSName(COSName.V);
+            if (appearanceEntry.getCOSObject().containsKey(value))
             {
-                widget.setAppearanceState(getCOSObject().getCOSName(COSName.V).getName());
+                widget.setAppearanceState(value.getName());
             }
             else
             {

Original file line number	Diff line number	Diff line change
`@@ -293,9 +293,10 @@ void constructAppearances() throws IOException`
`293`	`293`	`continue;`
`294`	`294`	`}`
`295`	`295`	`PDAppearanceEntry appearanceEntry = appearance.getNormalAppearance();`
`296`		`- if (appearanceEntry.getCOSObject().containsKey(getCOSObject().getCOSName(COSName.V)))`
	`296`	`+ COSName value = getCOSObject().getCOSName(COSName.V);`
	`297`	`+ if (appearanceEntry.getCOSObject().containsKey(value))`
`297`	`298`	`{`
`298`		`- widget.setAppearanceState(getCOSObject().getCOSName(COSName.V).getName());`
	`299`	`+ widget.setAppearanceState(value.getName());`
`299`	`300`	`}`
`300`	`301`	`else`
`301`	`302`	`{`