PDFBOX-5660: Sonar fix

THausherr · THausherr · commit 03f99dda18aa · 2025-04-07T14:19:56.000Z
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1924910 13f79535-47bb-0310-9956-ffa450edef68
diff --git a/pdfbox/src/main/java/org/apache/pdfbox/cos/COSUpdateState.java b/pdfbox/src/main/java/org/apache/pdfbox/cos/COSUpdateState.java
@@ -152,10 +152,13 @@ else if(updateInfo instanceof COSArray)
         else if(updateInfo instanceof COSObject)
         {
             COSObject object = (COSObject) updateInfo;
-            COSBase reference;
-            if(object.isDereferenced() && (reference = object.getObject()) instanceof COSUpdateInfo)
+            if (object.isDereferenced())
             {
-                ((COSUpdateInfo) reference).getUpdateState().setOriginDocumentState(originDocumentState, dereferencing);
+                COSBase reference = object.getObject();
+                if (reference instanceof COSUpdateInfo)
+                {
+                    ((COSUpdateInfo) reference).getUpdateState().setOriginDocumentState(originDocumentState, dereferencing);
+                }
             }
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -152,10 +152,13 @@ else if(updateInfo instanceof COSArray)`
`152`	`152`	`else if(updateInfo instanceof COSObject)`
`153`	`153`	`{`
`154`	`154`	`COSObject object = (COSObject) updateInfo;`
`155`		`- COSBase reference;`
`156`		`- if(object.isDereferenced() && (reference = object.getObject()) instanceof COSUpdateInfo)`
	`155`	`+ if (object.isDereferenced())`
`157`	`156`	`{`
`158`		`- ((COSUpdateInfo) reference).getUpdateState().setOriginDocumentState(originDocumentState, dereferencing);`
	`157`	`+ COSBase reference = object.getObject();`
	`158`	`+ if (reference instanceof COSUpdateInfo)`
	`159`	`+ {`
	`160`	`+ ((COSUpdateInfo) reference).getUpdateState().setOriginDocumentState(originDocumentState, dereferencing);`
	`161`	`+ }`
`159`	`162`	`}`
`160`	`163`	`}`
`161`	`164`	`}`