PDFBOX-5660: refactor, as suggested by Valery Bokov; closes #249

git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1928328 13f79535-47bb-0310-9956-ffa450edef68

Author: THausherr

pdfbox/src/main/java/org/apache/pdfbox/pdmodel/fdf/FDFAnnotation.java

@@ -320,6 +320,16 @@ final float[] parseRectangleAttributes(String rect, String errorMessage) throws
         return values;
     }
 
+    final float[] parseFloats(String[] srcValues)
+    {
+        float[] values = new float[srcValues.length];
+        for (int i = 0; i < srcValues.length; i++)
+        {
+            values[i] = Float.parseFloat(srcValues[i]);
+        }
+        return values;
+    }
+
     final PDRectangle createRectangleFromAttributes(String rect, String errorMessage) throws IOException
     {
         String[] rectValues = rect.split(",");

pdfbox/src/main/java/org/apache/pdfbox/pdmodel/fdf/FDFAnnotationFreeText.java

@@ -116,11 +116,7 @@ private void initCallout(Element element)
         if (callout != null && !callout.isEmpty())
         {
             String[] calloutValues = callout.split(",");
-            float[] values = new float[calloutValues.length];
-            for (int i = 0; i < calloutValues.length; i++)
-            {
-                values[i] = Float.parseFloat(calloutValues[i]);
-            }
+            float[] values = parseFloats(calloutValues);
             setCallout(values);
         }
     }

pdfbox/src/main/java/org/apache/pdfbox/pdmodel/fdf/FDFAnnotationInk.java

@@ -96,11 +96,7 @@ public FDFAnnotationInk(Element element) throws IOException
                 {
                     String gesture = node.getFirstChild().getNodeValue();
                     String[] gestureValues = gesture.split("[,;]");
-                    float[] values = new float[gestureValues.length];
-                    for (int j = 0; j < gestureValues.length; j++)
-                    {
-                        values[j] = Float.parseFloat(gestureValues[j]);
-                    }
+                    float[] values = parseFloats(gestureValues);
                     inklist.add(values);
                 }
             }

pdfbox/src/main/java/org/apache/pdfbox/pdmodel/fdf/FDFAnnotationPolygon.java

@@ -95,11 +95,7 @@ private void initVertices(Element element) throws IOException
                 throw new IOException("Error: missing element 'vertices'");
             }
             String[] verticesValues = vertices.split(",|;");
-            float[] values = new float[verticesValues.length];
-            for (int i = 0; i < verticesValues.length; i++)
-            {
-                values[i] = Float.parseFloat(verticesValues[i]);
-            }
+            float[] values = parseFloats(verticesValues);
             setVertices(values);
         }
         catch (XPathExpressionException e)

pdfbox/src/main/java/org/apache/pdfbox/pdmodel/fdf/FDFAnnotationPolyline.java

@@ -91,11 +91,7 @@ private void initVertices(Element element) throws IOException
                 throw new IOException("Error: missing element 'vertices'");
             }
             String[] verticesValues = vertices.split("[,;]");
-            float[] values = new float[verticesValues.length];
-            for (int i = 0; i < verticesValues.length; i++)
-            {
-                values[i] = Float.parseFloat(verticesValues[i]);
-            }
+            float[] values = parseFloats(verticesValues);
             setVertices(values);
         }
         catch (XPathExpressionException e)

pdfbox/src/main/java/org/apache/pdfbox/pdmodel/fdf/FDFAnnotationTextMarkup.java

@@ -68,11 +68,7 @@ protected FDFAnnotationTextMarkup(Element element) throws IOException
         {
             throw new IOException("Error: too little numbers in attribute 'coords'");
         }
-        float[] values = new float[coordsValues.length];
-        for (int i = 0; i < coordsValues.length; i++)
-        {
-            values[i] = Float.parseFloat(coordsValues[i]);
-        }
+        float[] values = parseFloats(coordsValues);
         setCoords(values);
     }