PDFBOX-6000: optimize if-clause as proposed by Tilman

lehmi · lehmi · commit 09dbd9c68822 · 2025-05-08T15:42:03.000Z
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1925464 13f79535-47bb-0310-9956-ffa450edef68
diff --git a/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/encoding/GlyphList.java b/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/encoding/GlyphList.java
@@ -236,7 +236,7 @@ else if ((name.length() == 7 && name.startsWith("uni"))
                     || (name.length() == 5 && name.startsWith("u")))
             {
                 // test for Unicode name in the format uniXXXX/uXXXX where X is hex
-                int start = name.startsWith("uni") ? 3 : 1;
+                int start = name.length() == 7 ? 3 : 1;
                 try
                 {
                     int codePoint = Integer.parseInt(name, start, start + 4, 16);

Original file line number	Diff line number	Diff line change
`@@ -236,7 +236,7 @@ else if ((name.length() == 7 && name.startsWith("uni"))`
`236`	`236`	`\|\| (name.length() == 5 && name.startsWith("u")))`
`237`	`237`	`{`
`238`	`238`	`// test for Unicode name in the format uniXXXX/uXXXX where X is hex`
`239`		`- int start = name.startsWith("uni") ? 3 : 1;`
	`239`	`+ int start = name.length() == 7 ? 3 : 1;`
`240`	`240`	`try`
`241`	`241`	`{`
`242`	`242`	`int codePoint = Integer.parseInt(name, start, start + 4, 16);`