PDFBOX-5660: simplify code, as suggested by Valery Bokov; closes #215

THausherr · THausherr · commit 09faf666f3fa · 2025-08-17T16:31:32.000Z
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1927838 13f79535-47bb-0310-9956-ffa450edef68
diff --git a/pdfbox/src/main/java/org/apache/pdfbox/util/NumberFormatUtil.java b/pdfbox/src/main/java/org/apache/pdfbox/util/NumberFormatUtil.java
@@ -132,7 +132,7 @@ private static int formatPositiveNumber(long number, int exp, boolean omitTraili
         int offset = startOffset;
         long remaining = number;
 
-        while (remaining > Integer.MAX_VALUE && (!omitTrailingZeros || remaining > 0))
+        while (remaining > Integer.MAX_VALUE)
         {
             long digit = remaining / POWER_OF_TENS[exp];
             remaining -= (digit * POWER_OF_TENS[exp]);

Original file line number	Diff line number	Diff line change
`@@ -132,7 +132,7 @@ private static int formatPositiveNumber(long number, int exp, boolean omitTraili`
`132`	`132`	`int offset = startOffset;`
`133`	`133`	`long remaining = number;`
`134`	`134`
`135`		`- while (remaining > Integer.MAX_VALUE && (!omitTrailingZeros \|\| remaining > 0))`
	`135`	`+ while (remaining > Integer.MAX_VALUE)`
`136`	`136`	`{`
`137`	`137`	`long digit = remaining / POWER_OF_TENS[exp];`
`138`	`138`	`remaining -= (digit * POWER_OF_TENS[exp]);`