PDFBOX-6053: catch negative MCID

git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1927910 13f79535-47bb-0310-9956-ffa450edef68

Author: THausherr

pdfbox/src/main/java/org/apache/pdfbox/pdmodel/documentinterchange/logicalstructure/PDMarkedContentReference.java

@@ -98,6 +98,10 @@ public int getMCID()
      */
     public void setMCID(int mcid)
     {
+        if (mcid < 0)
+        {
+            throw new IllegalArgumentException("MCID is negative");
+        }
         this.getCOSObject().setInt(COSName.MCID, mcid);
     }
 

pdfbox/src/test/java/org/apache/pdfbox/pdmodel/documentinterchange/logicalstructure/PDStructureElementTest.java

@@ -177,7 +177,8 @@ void testSimple()
         PDMarkedContent mc2 = PDMarkedContent.create(COSName.S, mcr2.getCOSObject());
         structureElement.appendKid(mc2);
         PDMarkedContentReference mcrSubZero = new PDMarkedContentReference();
-        mcrSubZero.setMCID(-1); //TODO should fail
+        assertThrows(IllegalArgumentException.class, () -> mcrSubZero.setMCID(-1));
+        mcrSubZero.getCOSObject().setInt(COSName.MCID, -1);
         PDMarkedContent mcSubZero = PDMarkedContent.create(COSName.S, mcrSubZero.getCOSObject());
         assertThrows(IllegalArgumentException.class, () -> structureElement.appendKid(mcSubZero));
         List<Object> kids = structureElement.getKids();