Skip to content

Commit 2917dd8

Browse files
committed
PDFBOX-3882: minor corrections, explain why test of getDerivedFromProperty() abandoned
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1930341 13f79535-47bb-0310-9956-ffa450edef68
1 parent aa4c13a commit 2917dd8

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

xmpbox/src/test/java/org/apache/xmpbox/xml/DomXmpParserTest.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -308,14 +308,13 @@ void testPDFBox3882() throws IOException, XmpParsingException
308308

309309
/**
310310
* PDFBOX-3882: Test ResourceEventType properties as attributes instead of properties (call of
311-
* tryParseAttributesAsProperties() the the end of parseLiElement())
311+
* tryParseAttributesAsProperties() at the end of parseLiElement())
312312
*
313313
* @throws XmpParsingException
314314
*/
315315
@Test
316316
void testPDFBox3882_2() throws XmpParsingException
317317
{
318-
319318
// data modified from XMP data in the JPEG file in Apache Tika JpegParserTest.testJPEGXMPMM()
320319
String s = "<?xpacket begin=\"\" id=\"W5M0MpCehiHzreSzNTczkc9d\"?>\n" +
321320
"<x:xmpmeta xmlns:x=\"adobe:ns:meta/\"\n" +
@@ -395,7 +394,6 @@ void testPDFBox3882_2() throws XmpParsingException
395394
assertEquals("xmp.iid:49E997338D4911E1AB62EBF9B374B234", xmpMediaManagementSchema.getInstanceID());
396395
assertEquals("xmp.did:49E997348D4911E1AB62EBF9B374B234", xmpMediaManagementSchema.getDocumentID());
397396
assertEquals("xmp.did:01801174072068118A6D9A879C818256", xmpMediaManagementSchema.getOriginalDocumentID());
398-
System.out.println("MediaManagementSchema all: " + xmpMediaManagementSchema.getAllProperties());
399397
PhotoshopSchema photoshopSchema = xmp.getPhotoshopSchema();
400398
assertEquals("2012-05-03T09:34:50-04:00\tFile i1222b.jpg opened\n", photoshopSchema.getHistory());
401399
ArrayProperty ancestorsProperty = (ArrayProperty) photoshopSchema.getProperty("DocumentAncestors");
@@ -404,6 +402,7 @@ void testPDFBox3882_2() throws XmpParsingException
404402
assertEquals("adobe:docid:photoshop:11d3ec5a-c131-11d8-9274-ec65c7d7e0c6", ((TextType) ancestors.get(0)).getStringValue());
405403
assertEquals("adobe:docid:photoshop:aadc7027-309c-11d8-9596-9cf45d2f630b", ((TextType) ancestors.get(1)).getStringValue());
406404
assertEquals("adobe:docid:photoshop:c7961c59-6e0f-11d8-87b7-d67539df12d8", ((TextType) ancestors.get(2)).getStringValue());
407-
ResourceRefType derivedFromProperty = xmpMediaManagementSchema.getDerivedFromProperty(); //TODO doesn't work yet?!
405+
// xmpMediaManagementSchema.getDerivedFromProperty() doesn't work.
406+
// However the PDFLib XMP validator considers this file to be invalid, so lets not bother more
408407
}
409408
}

0 commit comments

Comments
 (0)