PDFBOX-5660: Sonar fix / avoid NPE

THausherr · THausherr · commit 2f29a619a1c8 · 2025-04-07T11:59:57.000Z
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1924898 13f79535-47bb-0310-9956-ffa450edef68
diff --git a/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/PDPageTree.java b/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/PDPageTree.java
@@ -209,14 +209,14 @@ else if (kid.containsKey(COSName.KIDS))
             }
             else
             {
-                if (COSName.PAGE.equals(node.getCOSName(COSName.TYPE)))
+                if (node != null && COSName.PAGE.equals(node.getCOSName(COSName.TYPE)))
                 {
                     queue.add(node);
                 }
                 else
                 {
                     LOG.error("Page skipped due to an invalid or missing type {}",
-                            node.getCOSName(COSName.TYPE));
+                            () -> (node == null ? "(null)" : node.getCOSName(COSName.TYPE)));
                 }
             }
         }

Original file line number	Diff line number	Diff line change
`@@ -209,14 +209,14 @@ else if (kid.containsKey(COSName.KIDS))`
`209`	`209`	`}`
`210`	`210`	`else`
`211`	`211`	`{`
`212`		`- if (COSName.PAGE.equals(node.getCOSName(COSName.TYPE)))`
	`212`	`+ if (node != null && COSName.PAGE.equals(node.getCOSName(COSName.TYPE)))`
`213`	`213`	`{`
`214`	`214`	`queue.add(node);`
`215`	`215`	`}`
`216`	`216`	`else`
`217`	`217`	`{`
`218`	`218`	`LOG.error("Page skipped due to an invalid or missing type {}",`
`219`		`- node.getCOSName(COSName.TYPE));`
	`219`	`+ () -> (node == null ? "(null)" : node.getCOSName(COSName.TYPE)));`
`220`	`220`	`}`
`221`	`221`	`}`
`222`	`222`	`}`