PDFBOX-5660: improve exception message

THausherr · THausherr · commit 37f950c167d3 · 2025-12-02T16:05:43.000Z
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1930197 13f79535-47bb-0310-9956-ffa450edef68
diff --git a/xmpbox/src/main/java/org/apache/xmpbox/xml/DomXmpParser.java b/xmpbox/src/main/java/org/apache/xmpbox/xml/DomXmpParser.java
@@ -478,9 +478,10 @@ private void manageArray(XMPMetadata xmp, Element property, PropertyType type, C
         {
             // not an array
             String whatFound = "nothing";
-            if (property.getFirstChild() != null)
+            Node firstChild = property.getFirstChild();
+            if (firstChild != null)
             {
-                whatFound = property.getFirstChild().getClass().getName();
+                whatFound = firstChild instanceof Text ? "Text" : firstChild.getClass().getName();
             }
             throw new XmpParsingException(ErrorType.Format, "Invalid array definition, expecting " + type.card()
                     + " and found "

Original file line number	Diff line number	Diff line change
`@@ -478,9 +478,10 @@ private void manageArray(XMPMetadata xmp, Element property, PropertyType type, C`
`478`	`478`	`{`
`479`	`479`	`// not an array`
`480`	`480`	`String whatFound = "nothing";`
`481`		`- if (property.getFirstChild() != null)`
	`481`	`+ Node firstChild = property.getFirstChild();`
	`482`	`+ if (firstChild != null)`
`482`	`483`	`{`
`483`		`- whatFound = property.getFirstChild().getClass().getName();`
	`484`	`+ whatFound = firstChild instanceof Text ? "Text" : firstChild.getClass().getName();`
`484`	`485`	`}`
`485`	`486`	`throw new XmpParsingException(ErrorType.Format, "Invalid array definition, expecting " + type.card()`
`486`	`487`	`+ " and found "`