Skip to content

Commit 3efb831

Browse files
committed
PDFBOX-5660: optimize, as suggested by Valery Bokov; closes #248
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1928287 13f79535-47bb-0310-9956-ffa450edef68
1 parent e7301d3 commit 3efb831

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

pdfbox/src/main/java/org/apache/pdfbox/pdmodel/fdf/FDFAnnotationInk.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,7 @@ public List<float[]> getInkList()
141141
COSArray array = annot.getCOSArray(COSName.INKLIST);
142142
if (array != null)
143143
{
144-
List<float[]> retval = new ArrayList<>();
144+
List<float[]> retval = new ArrayList<>(array.size());
145145
for (COSBase entry : array)
146146
{
147147
retval.add(((COSArray) entry).toFloatArray());

pdfbox/src/main/java/org/apache/pdfbox/pdmodel/fdf/FDFDictionary.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -328,7 +328,7 @@ public List<FDFField> getFields()
328328
COSArray fieldArray = fdf.getCOSArray(COSName.FIELDS);
329329
if (fieldArray != null)
330330
{
331-
List<FDFField> fields = new ArrayList<>();
331+
List<FDFField> fields = new ArrayList<>(fieldArray.size());
332332
for (int i = 0; i < fieldArray.size(); i++)
333333
{
334334
fields.add(new FDFField((COSDictionary) fieldArray.getObject(i)));
@@ -379,7 +379,7 @@ public List<FDFPage> getPages()
379379
COSArray pageArray = fdf.getCOSArray(COSName.PAGES);
380380
if (pageArray != null)
381381
{
382-
List<FDFPage> pages = new ArrayList<>();
382+
List<FDFPage> pages = new ArrayList<>(pageArray.size());
383383
for (int i = 0; i < pageArray.size(); i++)
384384
{
385385
pages.add(new FDFPage((COSDictionary) pageArray.get(i)));
@@ -440,7 +440,7 @@ public List<FDFAnnotation> getAnnotations() throws IOException
440440
COSArray annotArray = fdf.getCOSArray(COSName.ANNOTS);
441441
if (annotArray != null)
442442
{
443-
List<FDFAnnotation> annots = new ArrayList<>();
443+
List<FDFAnnotation> annots = new ArrayList<>(annotArray.size());
444444
for (int i = 0; i < annotArray.size(); i++)
445445
{
446446
annots.add(FDFAnnotation.create((COSDictionary) annotArray.getObject(i)));
@@ -515,7 +515,7 @@ public List<PDFileSpecification> getEmbeddedFDFs() throws IOException
515515
COSArray embeddedArray = fdf.getCOSArray(COSName.EMBEDDED_FDFS);
516516
if (embeddedArray != null)
517517
{
518-
List<PDFileSpecification> embedded = new ArrayList<>();
518+
List<PDFileSpecification> embedded = new ArrayList<>(embeddedArray.size());
519519
for (int i = 0; i < embeddedArray.size(); i++)
520520
{
521521
embedded.add(PDFileSpecification.createFS(embeddedArray.get(i)));

pdfbox/src/main/java/org/apache/pdfbox/pdmodel/fdf/FDFTemplate.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ public List<FDFField> getFields()
9494
COSArray array = template.getCOSArray(COSName.FIELDS);
9595
if (array != null)
9696
{
97-
List<FDFField> fields = new ArrayList<>();
97+
List<FDFField> fields = new ArrayList<>(array.size());
9898
for (int i = 0; i < array.size(); i++)
9999
{
100100
fields.add(new FDFField((COSDictionary) array.getObject(i)));

0 commit comments

Comments
 (0)