Skip to content

Commit 43b1f8c

Browse files
committed
PDFBOX-5660: remove unneeded cast
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1924362 13f79535-47bb-0310-9956-ffa450edef68
1 parent ab81aa5 commit 43b1f8c

File tree

1 file changed

+11
-13
lines changed

1 file changed

+11
-13
lines changed

pdfbox/src/test/java/org/apache/pdfbox/cos/TestCOSArray.java

Lines changed: 11 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@
2424
import java.util.Arrays;
2525
import java.util.List;
2626

27-
import org.apache.pdfbox.pdmodel.common.COSObjectable;
2827
import org.junit.jupiter.api.Assertions;
2928
import org.junit.jupiter.api.Test;
3029

@@ -38,8 +37,7 @@ void testCreate()
3837
{
3938
COSArray cosArray = new COSArray();
4039
assertEquals(0, cosArray.size());
41-
Assertions.assertThrows(NullPointerException.class, () -> new COSArray(
42-
(List<? extends COSObjectable>) null),
40+
Assertions.assertThrows(NullPointerException.class, () -> new COSArray(null),
4341
"Constructor should have thrown an exception");
4442

4543
cosArray = new COSArray(Arrays.asList(COSName.A, COSName.B, COSName.C));
@@ -114,7 +112,7 @@ void testConvertInteger2COSStringAndBack()
114112
@Test
115113
void testConvertFloat2COSStringAndBack()
116114
{
117-
float[] floatArrayStart = { 1.0f, 0.1f, 0.02f };
115+
float[] floatArrayStart = { 1f, 0.1f, 0.02f };
118116
COSArray cosArray = new COSArray();
119117
cosArray.setFloatArray(floatArrayStart);
120118

@@ -125,14 +123,14 @@ void testConvertFloat2COSStringAndBack()
125123

126124
List<Float> cosNumberFloatList = cosArray.toCOSNumberFloatList();
127125
assertEquals(3, cosNumberFloatList.size());
128-
assertEquals(1.0f, (float) cosNumberFloatList.get(0), 0);
129-
assertEquals(0.1f, (float) cosNumberFloatList.get(1), 0);
130-
assertEquals(0.02f, (float) cosNumberFloatList.get(2), 0);
126+
assertEquals(1f, cosNumberFloatList.get(0), 0);
127+
assertEquals(0.1f, cosNumberFloatList.get(1), 0);
128+
assertEquals(0.02f, cosNumberFloatList.get(2), 0);
131129

132130
float[] floatArrayEnd = cosArray.toFloatArray();
133-
assertEquals(1.0f, (float) cosNumberFloatList.get(0), 0);
134-
assertEquals(0.1f, (float) cosNumberFloatList.get(1), 0);
135-
assertEquals(0.02f, (float) cosNumberFloatList.get(2), 0);
131+
assertEquals(1f, cosNumberFloatList.get(0), 0);
132+
assertEquals(0.1f, cosNumberFloatList.get(1), 0);
133+
assertEquals(0.02f, cosNumberFloatList.get(2), 0);
136134
assertArrayEquals(floatArrayStart, floatArrayEnd, 0);
137135

138136
// check arrays with null values
@@ -144,13 +142,13 @@ void testConvertFloat2COSStringAndBack()
144142

145143
cosNumberFloatList = cosArray.toCOSNumberFloatList();
146144
assertEquals(3, cosNumberFloatList.size());
147-
assertEquals(1.0f, (float) cosNumberFloatList.get(0), 0);
145+
assertEquals(1f, cosNumberFloatList.get(0), 0);
148146
assertNull(cosNumberFloatList.get(1));
149-
assertEquals(0.02f, (float) cosNumberFloatList.get(2), 0);
147+
assertEquals(0.02f, cosNumberFloatList.get(2), 0);
150148

151149
floatArrayEnd = cosArray.toFloatArray();
152150
// due to the null value the second value of the array is set to 0
153-
assertArrayEquals(new float[] { 1.0f, 0f, 0.02f }, floatArrayEnd, 0);
151+
assertArrayEquals(new float[] { 1f, 0, 0.02f }, floatArrayEnd, 0);
154152

155153
}
156154

0 commit comments

Comments
 (0)