PDFBOX-5660: optimize, as suggested by Valery Bokov; closes #323

THausherr · THausherr · commit 4628de165b6e · 2025-11-15T14:42:59.000Z
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1929767 13f79535-47bb-0310-9956-ffa450edef68
diff --git a/fontbox/src/main/java/org/apache/fontbox/util/autodetect/WindowsFontDirFinder.java b/fontbox/src/main/java/org/apache/fontbox/util/autodetect/WindowsFontDirFinder.java
@@ -51,7 +51,6 @@ public List<File> find()
             LOG.debug("Couldn't get Windows font directories - ignoring", e);
             // should continue if this fails
         }
-        String osName = System.getProperty("os.name");
         if (windir == null)
         {
             try
@@ -86,6 +85,7 @@ public List<File> find()
         }
         else
         {
+            String osName = System.getProperty("os.name");
             String windowsDirName = osName.endsWith("NT") ? "WINNT" : "WINDOWS";
             // look for true type font folder
             for (char driveLetter = 'C'; driveLetter <= 'E'; driveLetter++)

Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,6 @@ public List<File> find()`
`51`	`51`	`LOG.debug("Couldn't get Windows font directories - ignoring", e);`
`52`	`52`	`// should continue if this fails`
`53`	`53`	`}`
`54`		`- String osName = System.getProperty("os.name");`
`55`	`54`	`if (windir == null)`
`56`	`55`	`{`
`57`	`56`	`try`
`@@ -86,6 +85,7 @@ public List<File> find()`
`86`	`85`	`}`
`87`	`86`	`else`
`88`	`87`	`{`
	`88`	`+ String osName = System.getProperty("os.name");`
`89`	`89`	`String windowsDirName = osName.endsWith("NT") ? "WINNT" : "WINDOWS";`
`90`	`90`	`// look for true type font folder`
`91`	`91`	`for (char driveLetter = 'C'; driveLetter <= 'E'; driveLetter++)`