PDFBOX-5660: Sonar fix

git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1924933 13f79535-47bb-0310-9956-ffa450edef68

Author: THausherr

examples/src/main/java/org/apache/pdfbox/examples/signature/CreateSignatureBase.java

@@ -61,7 +61,7 @@ public abstract class CreateSignatureBase implements SignatureInterface
      * @throws CertificateException if the certificate is not valid as signing time
      * @throws IOException if no certificate could be found
      */
-    public CreateSignatureBase(KeyStore keystore, char[] pin)
+    protected CreateSignatureBase(KeyStore keystore, char[] pin)
             throws KeyStoreException, UnrecoverableKeyException, NoSuchAlgorithmException, IOException, CertificateException
     {
         // grabs the first alias from the keystore and get the private key. An

fontbox/src/main/java/org/apache/fontbox/ttf/table/common/CoverageTable.java

@@ -29,7 +29,7 @@ public abstract class CoverageTable
 {
     private final int coverageFormat;
 
-    public CoverageTable(int coverageFormat)
+    protected CoverageTable(int coverageFormat)
     {
         this.coverageFormat = coverageFormat;
     }

fontbox/src/main/java/org/apache/fontbox/ttf/table/common/LookupSubTable.java

@@ -30,7 +30,7 @@ public abstract class LookupSubTable
     private final int substFormat;
     private final CoverageTable coverageTable;
 
-    public LookupSubTable(int substFormat, CoverageTable coverageTable)
+    protected LookupSubTable(int substFormat, CoverageTable coverageTable)
     {
         this.substFormat = substFormat;
         this.coverageTable = coverageTable;

pdfbox/src/main/java/org/apache/pdfbox/cos/COSBase.java

@@ -34,7 +34,7 @@ public abstract class COSBase implements COSObjectable
     /**
      * Constructor.
      */
-    public COSBase()
+    protected COSBase()
     {
     }
 

pdfbox/src/main/java/org/apache/pdfbox/pdmodel/common/filespecification/PDEmbeddedFile.java

@@ -62,9 +62,6 @@ public PDEmbeddedFile( PDDocument doc, InputStream str  ) throws IOException
 
     /**
      * {@inheritDoc}
-     * @param filter Filter to apply to the stream.
-     *
-     * @throws IOException {@inheritDoc}
      */
     public PDEmbeddedFile(PDDocument doc, InputStream input, COSName filter) throws IOException
     {

pdfbox/src/main/java/org/apache/pdfbox/pdmodel/common/function/PDFunction.java

@@ -50,7 +50,7 @@ public abstract class PDFunction implements COSObjectable
      * @param function The function stream.
      * 
      */
-    public PDFunction( COSBase function )
+    protected PDFunction( COSBase function )
     {
         if (function instanceof COSStream)
         {

pdfbox/src/main/java/org/apache/pdfbox/pdmodel/documentinterchange/logicalstructure/PDAttributeObject.java

@@ -40,7 +40,7 @@ public abstract class PDAttributeObject extends PDDictionaryWrapper
     /**
      * Default constructor.
      */
-    public PDAttributeObject()
+    protected PDAttributeObject()
     {
     }
 
@@ -49,7 +49,7 @@ public PDAttributeObject()
      * 
      * @param dictionary the dictionary
      */
-    public PDAttributeObject(COSDictionary dictionary)
+    protected PDAttributeObject(COSDictionary dictionary)
     {
         super(dictionary);
     }

pdfbox/src/main/java/org/apache/pdfbox/pdmodel/documentinterchange/taggedpdf/PDStandardAttributeObject.java

@@ -41,7 +41,7 @@ public abstract class PDStandardAttributeObject extends PDAttributeObject
     /**
      * Default constructor.
      */
-    public PDStandardAttributeObject()
+    protected PDStandardAttributeObject()
     {
     }
 
@@ -50,7 +50,7 @@ public PDStandardAttributeObject()
      * 
      * @param dictionary the dictionary
      */
-    public PDStandardAttributeObject(COSDictionary dictionary)
+    protected PDStandardAttributeObject(COSDictionary dictionary)
     {
         super(dictionary);
     }

pdfbox/src/main/java/org/apache/pdfbox/pdmodel/fdf/FDFAnnotation.java

@@ -104,7 +104,7 @@ public abstract class FDFAnnotation implements COSObjectable
     /**
      * Default constructor.
      */
-    public FDFAnnotation()
+    protected FDFAnnotation()
     {
         annot = new COSDictionary();
         annot.setItem(COSName.TYPE, COSName.ANNOT);
@@ -115,7 +115,7 @@ public FDFAnnotation()
      *
      * @param a The FDF annotation.
      */
-    public FDFAnnotation(COSDictionary a)
+    protected FDFAnnotation(COSDictionary a)
     {
         annot = a;
     }
@@ -127,7 +127,7 @@ public FDFAnnotation(COSDictionary a)
      *
      * @throws IOException If there is an error extracting data from the element.
      */
-    public FDFAnnotation(Element element) throws IOException
+    protected FDFAnnotation(Element element) throws IOException
     {
         this();
 

pdfbox/src/main/java/org/apache/pdfbox/pdmodel/fdf/FDFAnnotationTextMarkup.java

@@ -33,17 +33,16 @@ public abstract class FDFAnnotationTextMarkup extends FDFAnnotation
     /**
      * Default constructor.
      */
-    public FDFAnnotationTextMarkup()
+    protected FDFAnnotationTextMarkup()
     {
-        super();
     }
 
     /**
      * Constructor.
      *
      * @param a An existing FDF Annotation.
      */
-    public FDFAnnotationTextMarkup(COSDictionary a)
+    protected FDFAnnotationTextMarkup(COSDictionary a)
     {
         super(a);
     }