PDFBOX-5660: optimize, as suggested by Valery Bokov; closes #301

THausherr · THausherr · commit 61d42534036e · 2025-10-30T20:27:41.000Z
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1929424 13f79535-47bb-0310-9956-ffa450edef68
diff --git a/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/color/PDDeviceGray.java b/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/color/PDDeviceGray.java
@@ -84,6 +84,7 @@ public BufferedImage toRGBImage(WritableRaster raster) throws IOException
         int height = raster.getHeight();
 
         BufferedImage image = new BufferedImage(width, height, BufferedImage.TYPE_INT_RGB);
+        WritableRaster dstRaster = image.getRaster();
 
         int[] gray = new int[1];
         int[] rgb = new int[3];
@@ -95,7 +96,7 @@ public BufferedImage toRGBImage(WritableRaster raster) throws IOException
                 rgb[0] = gray[0];
                 rgb[1] = gray[0];
                 rgb[2] = gray[0];
-                image.getRaster().setPixel(x, y, rgb);
+                dstRaster.setPixel(x, y, rgb);
             }
         }
 

Original file line number	Diff line number	Diff line change
`@@ -84,6 +84,7 @@ public BufferedImage toRGBImage(WritableRaster raster) throws IOException`
`84`	`84`	`int height = raster.getHeight();`
`85`	`85`
`86`	`86`	`BufferedImage image = new BufferedImage(width, height, BufferedImage.TYPE_INT_RGB);`
	`87`	`+ WritableRaster dstRaster = image.getRaster();`
`87`	`88`
`88`	`89`	`int[] gray = new int[1];`
`89`	`90`	`int[] rgb = new int[3];`
`@@ -95,7 +96,7 @@ public BufferedImage toRGBImage(WritableRaster raster) throws IOException`
`95`	`96`	`rgb[0] = gray[0];`
`96`	`97`	`rgb[1] = gray[0];`
`97`	`98`	`rgb[2] = gray[0];`
`98`		`- image.getRaster().setPixel(x, y, rgb);`
	`99`	`+ dstRaster.setPixel(x, y, rgb);`
`99`	`100`	`}`
`100`	`101`	`}`
`101`	`102`