Skip to content

Commit 64f34c8

Browse files
committed
PDFBOX-5660: improve test coverage
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1927888 13f79535-47bb-0310-9956-ffa450edef68
1 parent 3d1c8ff commit 64f34c8

File tree

1 file changed

+14
-3
lines changed

1 file changed

+14
-3
lines changed

pdfbox/src/test/java/org/apache/pdfbox/multipdf/PDFMergerUtilityTest.java

Lines changed: 14 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,8 @@
3636
import org.apache.pdfbox.cos.COSName;
3737
import org.apache.pdfbox.cos.COSObject;
3838
import org.apache.pdfbox.io.IOUtils;
39+
import org.apache.pdfbox.io.RandomAccessRead;
40+
import org.apache.pdfbox.io.RandomAccessReadBufferedFile;
3941
import org.apache.pdfbox.io.RandomAccessStreamCache.StreamCacheCreateFunction;
4042
import org.apache.pdfbox.pdmodel.PDDocument;
4143
import org.apache.pdfbox.pdmodel.PDDocumentCatalog;
@@ -778,17 +780,26 @@ void testFileDeletion() throws IOException
778780
createSimpleFile(inFile1);
779781
createSimpleFile(inFile2);
780782

781-
try (OutputStream out = new FileOutputStream(outFile))
783+
try (OutputStream out = new FileOutputStream(outFile);
784+
// Unrelated: increase test coverage by testing RandomAccessRead
785+
RandomAccessRead rar1 = new RandomAccessReadBufferedFile(inFile1);
786+
RandomAccessRead rar2 = new RandomAccessReadBufferedFile(inFile2))
782787
{
783788
PDFMergerUtility merger = new PDFMergerUtility();
784789
merger.setDestinationStream(out);
790+
assertEquals(out, merger.getDestinationStream());
785791

786-
merger.addSource(inFile1);
787-
merger.addSource(inFile2);
792+
merger.addSource(rar1);
793+
merger.addSource(rar2);
788794

789795
merger.mergeDocuments(IOUtils.createMemoryOnlyStreamCache());
790796
}
791797

798+
try (PDDocument doc = Loader.loadPDF(outFile))
799+
{
800+
assertEquals(2, doc.getNumberOfPages());
801+
}
802+
792803
Files.delete(inFile1.toPath());
793804
Files.delete(inFile2.toPath());
794805
Files.delete(outFile.toPath());

0 commit comments

Comments
 (0)