Skip to content

Commit 6833a8c

Browse files
committed
PDFBOX-5660: close input, as suggested by Valery Bokov; closes #293
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1929339 13f79535-47bb-0310-9956-ffa450edef68
1 parent 4f0a2dc commit 6833a8c

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

pdfbox/src/test/java/org/apache/pdfbox/pdmodel/graphics/image/PNGConverterTest.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -166,9 +166,9 @@ void testImageConversionGrayGamma() throws IOException
166166

167167
private void checkImageConvertFail(String name) throws IOException
168168
{
169-
try (PDDocument doc = new PDDocument())
169+
try (PDDocument doc = new PDDocument();
170+
InputStream in = PNGConverterTest.class.getResourceAsStream(name))
170171
{
171-
InputStream in = PNGConverterTest.class.getResourceAsStream(name);
172172
byte[] imageBytes = in.readAllBytes();
173173
PDImageXObject pdImageXObject = PNGConverter.convertPNGImage(doc, imageBytes);
174174
assertNull(pdImageXObject);
@@ -177,9 +177,9 @@ private void checkImageConvertFail(String name) throws IOException
177177

178178
private void checkImageConvert(String name) throws IOException
179179
{
180-
try (PDDocument doc = new PDDocument())
180+
try (PDDocument doc = new PDDocument();
181+
InputStream in = PNGConverterTest.class.getResourceAsStream(name))
181182
{
182-
InputStream in = PNGConverterTest.class.getResourceAsStream(name);
183183
byte[] imageBytes = in.readAllBytes();
184184
PDImageXObject pdImageXObject = PNGConverter.convertPNGImage(doc, imageBytes);
185185
assertNotNull(pdImageXObject);
@@ -369,9 +369,9 @@ void testImageConversionIntentIndexed() throws IOException
369369
{
370370
checkImageConvert("929316.png");
371371

372-
try (PDDocument doc = new PDDocument())
372+
try (PDDocument doc = new PDDocument();
373+
InputStream in = PNGConverterTest.class.getResourceAsStream("929316.png"))
373374
{
374-
InputStream in = PNGConverterTest.class.getResourceAsStream("929316.png");
375375
byte[] imageBytes = in.readAllBytes();
376376
PDImageXObject pdImageXObject = PNGConverter.convertPNGImage(doc, imageBytes);
377377
assertEquals(COSName.PERCEPTUAL, pdImageXObject.getCOSObject().getItem(COSName.INTENT));

0 commit comments

Comments
 (0)