PDFBOX-5660: optimize, as suggested by Valery Bokov; closes #241

THausherr · THausherr · commit 6d202913cea0 · 2025-08-30T18:38:55.000Z
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1928127 13f79535-47bb-0310-9956-ffa450edef68
diff --git a/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/common/PDNameTreeNode.java b/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/common/PDNameTreeNode.java
@@ -255,12 +255,13 @@ public Map<String, T> getNames() throws IOException
         COSArray namesArray = node.getCOSArray(COSName.NAMES);
         if( namesArray != null )
         {
-            Map<String, T> names = new LinkedHashMap<>();
+            int size = namesArray.size();
+            Map<String, T> names = new LinkedHashMap<>(size);
             if (namesArray.size() % 2 != 0)
             {
-                LOG.warn("Names array has odd size: {}", namesArray.size());
+                LOG.warn("Names array has odd size: {}", size);
             }
-            for (int i = 0; i + 1 < namesArray.size(); i += 2)
+            for (int i = 0; i + 1 < size; i += 2)
             {
                 COSBase base = namesArray.getObject(i);
                 if (!(base instanceof COSString))

Original file line number	Diff line number	Diff line change
`@@ -255,12 +255,13 @@ public Map<String, T> getNames() throws IOException`
`255`	`255`	`COSArray namesArray = node.getCOSArray(COSName.NAMES);`
`256`	`256`	`if( namesArray != null )`
`257`	`257`	`{`
`258`		`- Map<String, T> names = new LinkedHashMap<>();`
	`258`	`+ int size = namesArray.size();`
	`259`	`+ Map<String, T> names = new LinkedHashMap<>(size);`
`259`	`260`	`if (namesArray.size() % 2 != 0)`
`260`	`261`	`{`
`261`		`- LOG.warn("Names array has odd size: {}", namesArray.size());`
	`262`	`+ LOG.warn("Names array has odd size: {}", size);`
`262`	`263`	`}`
`263`		`- for (int i = 0; i + 1 < namesArray.size(); i += 2)`
	`264`	`+ for (int i = 0; i + 1 < size; i += 2)`
`264`	`265`	`{`
`265`	`266`	`COSBase base = namesArray.getObject(i);`
`266`	`267`	`if (!(base instanceof COSString))`