PDFBOX-5660: optimize, as suggested by Valery Bokov; closes #349

THausherr · THausherr · commit 6e4e45bd6074 · 2025-11-25T18:40:10.000Z
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1930003 13f79535-47bb-0310-9956-ffa450edef68
diff --git a/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/AppearanceGeneratorHelper.java b/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/AppearanceGeneratorHelper.java
@@ -285,9 +285,9 @@ private String getFormattedValue(String apValue)
         PDAction actionF = actions.getF();
         if (actionF != null)
         {
-            if (field.getAcroForm().getScriptingHandler() != null)
+            ScriptingHandler scriptingHandler = field.getAcroForm().getScriptingHandler();
+            if (scriptingHandler != null)
             {
-                ScriptingHandler scriptingHandler = field.getAcroForm().getScriptingHandler();
                 return scriptingHandler.format((PDActionJavaScript) actionF, apValue);
             }
             LOG.info("Field contains a formatting action but no ScriptingHandler " +

Original file line number	Diff line number	Diff line change
`@@ -285,9 +285,9 @@ private String getFormattedValue(String apValue)`
`285`	`285`	`PDAction actionF = actions.getF();`
`286`	`286`	`if (actionF != null)`
`287`	`287`	`{`
`288`		`- if (field.getAcroForm().getScriptingHandler() != null)`
	`288`	`+ ScriptingHandler scriptingHandler = field.getAcroForm().getScriptingHandler();`
	`289`	`+ if (scriptingHandler != null)`
`289`	`290`	`{`
`290`		`- ScriptingHandler scriptingHandler = field.getAcroForm().getScriptingHandler();`
`291`	`291`	`return scriptingHandler.format((PDActionJavaScript) actionF, apValue);`
`292`	`292`	`}`
`293`	`293`	`LOG.info("Field contains a formatting action but no ScriptingHandler " +`