PDFBOX-5660: optimize, as suggested by Valery Bokov; refactor; closes #312

git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1929499 13f79535-47bb-0310-9956-ffa450edef68

Author: THausherr

fontbox/src/main/java/org/apache/fontbox/cff/CFFParser.java

@@ -994,13 +994,14 @@ private void readSupplement(DataInput dataInput, CFFBuiltInEncoding encoding)
             throws IOException
     {
         int nSups = dataInput.readUnsignedByte();
-        encoding.supplement = new CFFBuiltInEncoding.Supplement[nSups];
+        CFFBuiltInEncoding.Supplement[] supplement = new CFFBuiltInEncoding.Supplement[nSups];
+        encoding.supplement = supplement;
         for (int i = 0; i < nSups; i++)
         {
             int code = dataInput.readUnsignedByte();
             int sid = dataInput.readUnsignedShort();
-            encoding.supplement[i] = new CFFBuiltInEncoding.Supplement(code, sid, readString(sid));
-            encoding.add(encoding.supplement[i]);
+            supplement[i] = new CFFBuiltInEncoding.Supplement(code, sid, readString(sid));
+            encoding.add(supplement[i]);
         }
     }