PDFBOX-5660: optimize, as suggested by Valery Bokov; closes #229

THausherr · THausherr · commit 7a438df2cdeb · 2025-08-30T14:55:28.000Z
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1928105 13f79535-47bb-0310-9956-ffa450edef68
diff --git a/pdfbox/src/main/java/org/apache/pdfbox/multipdf/Overlay.java b/pdfbox/src/main/java/org/apache/pdfbox/multipdf/Overlay.java
@@ -335,8 +335,9 @@ private LayoutPage createLayoutPage(PDPage page) throws IOException
     private Map<Integer,LayoutPage> createPageOverlayLayoutPageMap(PDDocument doc) throws IOException
     {
         int i = 0;
-        Map<Integer, LayoutPage> layoutPages = new HashMap<>();
-        for (PDPage page : doc.getPages())
+        PDPageTree pageTree = doc.getPages();
+        Map<Integer, LayoutPage> layoutPages = new HashMap<>(pageTree.getCount());
+        for (PDPage page : pageTree)
         {
             layoutPages.put(i, createLayoutPage(page));
             i++;

Original file line number	Diff line number	Diff line change
`@@ -335,8 +335,9 @@ private LayoutPage createLayoutPage(PDPage page) throws IOException`
`335`	`335`	`private Map<Integer,LayoutPage> createPageOverlayLayoutPageMap(PDDocument doc) throws IOException`
`336`	`336`	`{`
`337`	`337`	`int i = 0;`
`338`		`- Map<Integer, LayoutPage> layoutPages = new HashMap<>();`
`339`		`- for (PDPage page : doc.getPages())`
	`338`	`+ PDPageTree pageTree = doc.getPages();`
	`339`	`+ Map<Integer, LayoutPage> layoutPages = new HashMap<>(pageTree.getCount());`
	`340`	`+ for (PDPage page : pageTree)`
`340`	`341`	`{`
`341`	`342`	`layoutPages.put(i, createLayoutPage(page));`
`342`	`343`	`i++;`