PDFBOX-6009: refactor

git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1925609 13f79535-47bb-0310-9956-ffa450edef68

Author: THausherr

pdfbox/src/main/java/org/apache/pdfbox/multipdf/Splitter.java

@@ -426,24 +426,7 @@ private COSBase createDictionaryClone(COSBase src, COSBase dstParent, COSDiction
                 else
                 {
                     // PDFBOX-6009: quit if MCIDs because these need a /Pg entry
-                    boolean hasMCIDs = false;
-                    if (kid instanceof COSInteger)
-                    {
-                        hasMCIDs = true;
-                    }
-                    else if (kid instanceof COSArray)
-                    {
-                        COSArray ar = (COSArray) kid;
-                        for (int i = 0; i < ar.size(); ++i)
-                        {
-                            if (ar.getObject(i) instanceof COSInteger)
-                            {
-                                hasMCIDs = true;
-                                break;
-                            }
-                        }
-                    }
-                    if (hasMCIDs)
+                    if (hasMCIDs(kid))
                     {
                         return null;
                     }
@@ -519,6 +502,26 @@ else if (kid instanceof COSArray)
             return dstDict;
         }
 
+        private boolean hasMCIDs(COSBase kid)
+        {
+            if (kid instanceof COSInteger)
+            {
+                return true;
+            }
+            if (kid instanceof COSArray)
+            {
+                COSArray ar = (COSArray) kid;
+                for (int i = 0; i < ar.size(); ++i)
+                {
+                    if (ar.getObject(i) instanceof COSInteger)
+                    {
+                        return true;
+                    }
+                }
+            }
+            return false;
+        }
+
         private void removePossibleOrphanAnnotation(COSDictionary srcObj, COSDictionary srcDict,
                 COSDictionary currentPageDict, COSDictionary dstDict)
         {