PDFBOX-6112: test simple values to increase test coverage

git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1930129 13f79535-47bb-0310-9956-ffa450edef68

Author: THausherr

xmpbox/src/test/java/org/apache/xmpbox/schema/PhotoshopSchemaTest.java

@@ -104,6 +104,15 @@ void testRandomPropertySetterSimple(String fieldName, Types type, Cardinality ca
         schemaTester.testRandomPropertySetterSimple();
     }
 
+    @ParameterizedTest
+    @MethodSource("initializeParameters")
+    void testRandomSetterSimple(String fieldName, Types type, Cardinality card)
+            throws ReflectiveOperationException
+    {
+        SchemaTester schemaTester = new SchemaTester(metadata, schemaClass, fieldName, type, card);
+        schemaTester.testRandomSetterSimple();
+    }
+
     @ParameterizedTest
     @MethodSource("initializeParameters")
     void testPropertySetterInArray(String fieldName, Types type, Cardinality card)

xmpbox/src/test/java/org/apache/xmpbox/schema/SchemaTester.java

@@ -201,6 +201,15 @@ public void testRandomPropertySetterSimple() throws ReflectiveOperationException
         }
     }
 
+    public void testRandomSetterSimple() throws ReflectiveOperationException
+    {
+        initializeSeed(new Random());
+        for (int i=0; i < RAND_LOOP_COUNT;i++)
+        {
+            internalTestSetterSimple();
+        }
+    }
+
     private void internalTestPropertySetterSimple() throws ReflectiveOperationException
     {
         if (cardinality != Cardinality.Simple)
@@ -283,4 +292,38 @@ protected String getPropertyQualifiedName(String name)
         sb.append(schema.getPrefix()).append(":").append(name);
         return sb.toString();
     }
+
+    // Test simple values to increase test coverage
+    private void internalTestSetterSimple() throws ReflectiveOperationException
+    {
+        if (cardinality != Cardinality.Simple)
+        {
+            return;
+        }
+
+        if (schemaClass == PhotoshopSchema.class && 
+                ("Urgency".equals(fieldName) || "ColorMode".equals(fieldName) || "DateCreated".equals(fieldName)))
+        {
+            // can't test these because return type != parameter (Urgency / ColorMode)
+            // or because value isn't expected parameter (DateCreated: getJavaValue() gives Calendar)
+            return;
+        }
+
+        XMPSchema schema = getSchema();
+
+        String setter = calculateSimpleSetter(fieldName);
+        Object value = getJavaValue(type);
+        AbstractSimpleProperty asp = typeMapping.instanciateSimpleProperty(schema.getNamespace(), schema
+                .getPrefix(), fieldName, value, type);
+        Method set = schemaClass.getMethod(setter, String.class);
+        set.invoke(schema, value);
+        // check property set
+        AbstractSimpleProperty stored = (AbstractSimpleProperty) schema.getProperty(fieldName);
+        assertEquals(value, stored.getValue());
+        // check getter
+        String getter = calculateSimpleGetter(fieldName);
+        Method get = schemaClass.getMethod(getter);
+        Object result = get.invoke(schema);
+        assertEquals(value, result);
+    }
 }