PDFBOX-5660: Sonar fix

git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1924852 13f79535-47bb-0310-9956-ffa450edef68

Author: THausherr

examples/src/test/java/org/apache/pdfbox/examples/pdfa/MergePDFATest.java

@@ -28,7 +28,7 @@
 import org.apache.pdfbox.examples.util.PDFMergerExample;
 import org.apache.pdfbox.io.RandomAccessRead;
 import org.apache.pdfbox.io.RandomAccessReadBufferedFile;
-import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.BeforeAll;
 import org.junit.jupiter.api.Test;
 import org.verapdf.core.VeraPDFException;
 import org.verapdf.gf.foundry.VeraGreenfieldFoundryProvider;
@@ -44,20 +44,20 @@
  */
 class MergePDFATest
 {
-    private final String outDir = "target/test-output";
+    private static final String OUTDIR = "target/test-output";
 
-    @BeforeEach
-    void setUp()
+    @BeforeAll
+    static void setUp()
     {
-        new File(outDir).mkdirs();
+        new File(OUTDIR).mkdirs();
     }
 
     @Test
     void testMergePDFA() throws IOException, TransformerException, VeraPDFException
     {
         System.out.println("testMergePDFA");
-        String pdfaFilename = outDir + "/Source_PDFA.pdf";
-        String pdfaMergedFilename = outDir + "/Merged_PDFA.pdf";
+        String pdfaFilename = OUTDIR + "/Source_PDFA.pdf";
+        String pdfaMergedFilename = OUTDIR + "/Merged_PDFA.pdf";
         String message = "The quick brown fox jumps over the lazy dog äöüÄÖÜß @°^²³ {[]}";
         String dir = "../pdfbox/src/main/resources/org/apache/pdfbox/resources/ttf/";
         String fontfile = dir + "LiberationSans-Regular.ttf";

pdfbox/src/test/java/org/apache/pdfbox/multipdf/MergeAcroFormsTest.java

@@ -32,7 +32,7 @@
 import org.apache.pdfbox.pdmodel.PDDocument;
 import org.apache.pdfbox.pdmodel.interactive.form.PDAcroForm;
 import org.apache.pdfbox.pdmodel.interactive.form.PDField;
-import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.BeforeAll;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.parallel.Execution;
 import org.junit.jupiter.api.parallel.ExecutionMode;
@@ -49,8 +49,8 @@ class MergeAcroFormsTest
     private static final File OUT_DIR = new File("target/test-output/merge/");
     private static final File TARGET_PDF_DIR = new File("target/pdfs");
 
-    @BeforeEach
-    public void setUp()
+    @BeforeAll
+    static void setUp()
     {
         OUT_DIR.mkdirs();
     }

pdfbox/src/test/java/org/apache/pdfbox/multipdf/MergeAnnotationsTest.java

@@ -30,7 +30,7 @@
 import org.apache.pdfbox.pdmodel.PDDocument;
 import org.apache.pdfbox.pdmodel.PDDocumentNameDestinationDictionary;
 import org.apache.pdfbox.pdmodel.interactive.annotation.PDAnnotation;
-import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.BeforeAll;
 import org.junit.jupiter.api.Test;
 
 /**
@@ -41,12 +41,12 @@ class MergeAnnotationsTest
     private static final File OUT_DIR = new File("target/test-output/merge/");
     private static final File TARGET_PDF_DIR = new File("target/pdfs");
 
-    @BeforeEach
-    public void setUp()
+    @BeforeAll
+    static void setUp()
     {
         OUT_DIR.mkdirs();
     }
-    
+
     /*
      * PDFBOX-1065 Ensure that after merging the PDFs there are all link
      * annotations and they point to the correct page.

pdfbox/src/test/java/org/apache/pdfbox/multipdf/OverlayTest.java

@@ -38,7 +38,7 @@
 import org.apache.pdfbox.rendering.PDFRenderer;
 
 import org.junit.jupiter.api.Assertions;
-import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.BeforeAll;
 import org.junit.jupiter.api.Test;
 
 /**
@@ -50,12 +50,8 @@ class OverlayTest
     private static final File IN_DIR = new File("src/test/resources/org/apache/pdfbox/multipdf");
     private static final File OUT_DIR = new File("target/test-output/overlay");
 
-    OverlayTest()
-    {
-    }
-
-    @BeforeEach
-    public void setUp()
+    @BeforeAll
+    static void setUp()
     {
         OUT_DIR.mkdirs();
     }

pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/documentnavigation/outline/PDOutlineItemTest.java

@@ -34,7 +34,7 @@ class PDOutlineItemTest
     private PDOutlineItem newSibling;
 
     @BeforeEach
-    public void setUp()
+    void setUp()
     {
         root = new PDOutlineItem();
         first = new PDOutlineItem();

pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/documentnavigation/outline/PDOutlineNodeTest.java

@@ -35,7 +35,7 @@ class PDOutlineNodeTest
     private PDOutlineItem root;
 
     @BeforeEach
-    public void setUp()
+    void setUp()
     {
         root = new PDOutlineItem();
     }

pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDChoiceTest.java

@@ -41,7 +41,7 @@ class PDChoiceTest
     private List<String> options;
 
     @BeforeEach
-    public void setUp()
+    void setUp()
     {
         document = new PDDocument();
         acroForm = new PDAcroForm(document);

pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDDefaultAppearanceStringTest.java

@@ -38,7 +38,7 @@ class PDDefaultAppearanceStringTest
     private PDType1Font helvetica; 
 
     @BeforeEach
-    public void setUp()
+    void setUp()
     {
         resources = new PDResources();
         helvetica = new PDType1Font(FontName.HELVETICA);

pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDSignatureFieldTest.java

@@ -43,7 +43,7 @@ class PDSignatureFieldTest
     private PDAcroForm acroForm;
 
     @BeforeEach
-    public void setUp()
+    void setUp()
     {
         document = new PDDocument();
         acroForm = new PDAcroForm(document);

pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDTextFieldTest.java

@@ -35,7 +35,7 @@ class PDTextFieldTest
     private PDAcroForm acroForm;
 
     @BeforeEach
-    public void setUp()
+    void setUp()
     {
         document = new PDDocument();
         acroForm = new PDAcroForm(document);