PDFBOX-6100: replace File.createTempFile to Files.createTempFile to reduce the read permission to local user, as suggested by Simon Steiner

git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1929734 13f79535-47bb-0310-9956-ffa450edef68

Author: THausherr

debugger/src/main/java/org/apache/pdfbox/debugger/ui/Tree.java

@@ -295,7 +295,7 @@ private JMenuItem getFileOpenMenu(final COSStream cosStream, final TreePath node
         {
             try
             {
-                File temp = File.createTempFile("pdfbox", "." + extension);
+                File temp = Files.createTempFile("pdfbox", "." + extension).toFile();
                 temp.deleteOnExit();
 
                 try (InputStream is = cosStream.createInputStream())

fontbox/src/test/java/org/apache/fontbox/ttf/RandomAccessReadBufferDataStreamTest.java

@@ -23,11 +23,11 @@
 
 import java.io.BufferedOutputStream;
 import java.io.EOFException;
-import java.io.File;
-import java.io.FileOutputStream;
 import java.io.IOException;
 import java.io.OutputStream;
 import java.nio.charset.StandardCharsets;
+import java.nio.file.Files;
+import java.nio.file.Path;
 
 import org.apache.pdfbox.io.RandomAccessRead;
 import org.apache.pdfbox.io.RandomAccessReadBuffer;
@@ -123,17 +123,17 @@ void testDoubleClose() throws IOException
     @Test
     void ensureReadFinishes() throws IOException
     {
-        final File file = File.createTempFile("apache-pdfbox", ".dat");
+        final Path path = Files.createTempFile("apache-pdfbox", ".dat");
 
-        try (OutputStream outputStream = new BufferedOutputStream(new FileOutputStream(file)))
+        try (OutputStream outputStream = new BufferedOutputStream(Files.newOutputStream(path)))
         {
             final String content = "1234567890";
             outputStream.write(content.getBytes(StandardCharsets.UTF_8));
             outputStream.flush();
         }
 
         final byte[] readBuffer = new byte[2];
-        RandomAccessRead randomAccessRead = new RandomAccessReadBufferedFile(file);
+        RandomAccessRead randomAccessRead = new RandomAccessReadBufferedFile(path.toFile());
         try (RandomAccessReadDataStream randomAccessReadDataStream = new RandomAccessReadDataStream(
                 randomAccessRead))
         {
@@ -145,7 +145,7 @@ void ensureReadFinishes() throws IOException
             }
             assertEquals(10, totalAmountRead);
         }
-        file.delete();
+        Files.delete(path);
     }
 
     /**
@@ -156,15 +156,15 @@ void ensureReadFinishes() throws IOException
     @Test
     void testReadBuffer() throws IOException
     {
-        final File file = File.createTempFile("apache-pdfbox", ".dat");
+        final Path path = Files.createTempFile("apache-pdfbox", ".dat");
 
-        try (OutputStream outputStream = new BufferedOutputStream(new FileOutputStream(file)))
+        try (OutputStream outputStream = new BufferedOutputStream(Files.newOutputStream(path)))
         {
             final String content = "012345678A012345678B012345678C012345678D";
             outputStream.write(content.getBytes(StandardCharsets.UTF_8));
             outputStream.flush();
         }
-        RandomAccessRead randomAccessRead = new RandomAccessReadBufferedFile(file);
+        RandomAccessRead randomAccessRead = new RandomAccessReadBufferedFile(path.toFile());
 
         final byte[] readBuffer = new byte[40];
         try (RandomAccessReadDataStream randomAccessReadDataStream = new RandomAccessReadDataStream(
@@ -238,7 +238,7 @@ void testReadBuffer() throws IOException
             assertEquals(count, bytesRead);
             assertEquals("012345678B012345678C012", new String(readBuffer, 0, count));
         }
-        file.delete();
+        Files.delete(path);
     }
 
 }

io/src/main/java/org/apache/pdfbox/io/ScratchFile.java

@@ -19,6 +19,7 @@
 import java.io.File;
 import java.io.FileNotFoundException;
 import java.io.IOException;
+import java.nio.file.Files;
 import java.util.ArrayList;
 import java.util.BitSet;
 import java.util.List;
@@ -253,7 +254,7 @@ private void enlarge() throws IOException
                 // create scratch file is needed
                 if ( raf == null )
                 {
-                    file = File.createTempFile("PDFBox", ".tmp", scratchFileDirectory);
+                    file = Files.createTempFile(scratchFileDirectory.toPath(), "PDFBox", ".tmp").toFile();
                     try
                     {
                         raf = new java.io.RandomAccessFile(file, "rw");

pdfbox/src/test/java/org/apache/pdfbox/rendering/TestPDFToImage.java

@@ -24,6 +24,7 @@
 import java.io.FileOutputStream;
 import java.io.FilenameFilter;
 import java.io.IOException;
+import java.nio.file.Files;
 import javax.imageio.ImageIO;
 import org.apache.logging.log4j.Logger;
 import org.apache.logging.log4j.LogManager;
@@ -207,7 +208,7 @@ public static boolean doTestFile(final File file, String inDir, String outDir)
 
             // test to see whether file is destroyed in pdfbox
             new FileOutputStream(new File(outDir, file.getName() + ".saveerror")).close();
-            File tmpFile = File.createTempFile("pdfbox", ".pdf");
+            File tmpFile = Files.createTempFile("pdfbox", ".pdf").toFile();
             document.setAllSecurityToBeRemoved(true);
             document.save(tmpFile);
             new File(outDir, file.getName() + ".saveerror").delete();