Skip to content

Commit 9c6b4bf

Browse files
committed
PDFBOX-6036: close InputStream as suggested by Valery Bokov
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1930652 13f79535-47bb-0310-9956-ffa450edef68
1 parent 9fd9120 commit 9c6b4bf

File tree

1 file changed

+13
-6
lines changed

1 file changed

+13
-6
lines changed

pdfbox/src/test/java/org/apache/pdfbox/pdfwriter/COSWriterTest.java

Lines changed: 13 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,10 @@
2323
import java.io.ByteArrayOutputStream;
2424
import java.io.File;
2525
import java.io.IOException;
26+
import java.io.InputStream;
2627
import java.net.URI;
2728
import java.net.URISyntaxException;
29+
import java.net.URL;
2830
import java.nio.file.Paths;
2931

3032
import org.apache.pdfbox.Loader;
@@ -153,13 +155,18 @@ private static byte[] edit(byte[] input) throws IOException
153155
@Test
154156
void testPDFBox5752() throws IOException, URISyntaxException
155157
{
158+
URL emptyURL = new URI(
159+
"https://issues.apache.org/jira/secure/attachment/13066015/empty.pdf").toURL();
160+
URL roboURL = new URI(
161+
"https://issues.apache.org/jira/secure/attachment/13066016/roboto-14.pdf").toURL();
162+
byte[] emptyPDF = null;
163+
byte[] roboPDF = null;
164+
try (InputStream isEmpty = emptyURL.openStream(); InputStream isRobo = roboURL.openStream())
165+
{
166+
emptyPDF = isEmpty.readAllBytes();
167+
roboPDF = isRobo.readAllBytes();
168+
}
156169
ByteArrayOutputStream baos = new ByteArrayOutputStream();
157-
byte[] emptyPDF = new URI(
158-
"https://issues.apache.org/jira/secure/attachment/13066015/empty.pdf").toURL()
159-
.openStream().readAllBytes();
160-
byte[] roboPDF = new URI(
161-
"https://issues.apache.org/jira/secure/attachment/13066016/roboto-14.pdf").toURL()
162-
.openStream().readAllBytes();
163170
try (PDDocument targetDoc = Loader.loadPDF(emptyPDF);
164171
PDDocument doc2 = Loader.loadPDF(roboPDF))
165172
{

0 commit comments

Comments
 (0)