PDFBOX-5660: optimize, as suggested by Valery Bokov; closes #278

THausherr · THausherr · commit a088a1ed6367 · 2025-10-08T12:34:11.000Z
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1929018 13f79535-47bb-0310-9956-ffa450edef68
diff --git a/fontbox/src/main/java/org/apache/fontbox/cff/CharStringCommand.java b/fontbox/src/main/java/org/apache/fontbox/cff/CharStringCommand.java
@@ -90,10 +90,10 @@ public enum CharStringCommand
 
     static
     {
-        int max = Arrays.stream(CharStringCommand.values()).mapToInt(CharStringCommand::getValue)
-                .max().orElseThrow();
+        CharStringCommand[] values = CharStringCommand.values();
+        int max = Arrays.stream(values).mapToInt(CharStringCommand::getValue).max().orElseThrow();
         COMMANDS_BY_VALUE = new CharStringCommand[max + 1];
-        Arrays.stream(CharStringCommand.values()).forEach(c -> COMMANDS_BY_VALUE[c.getValue()] = c);
+        Arrays.stream(values).forEach(c -> COMMANDS_BY_VALUE[c.getValue()] = c);
     }
 
     private final Type1KeyWord type1KeyWord;

Original file line number	Diff line number	Diff line change
`@@ -90,10 +90,10 @@ public enum CharStringCommand`
`90`	`90`
`91`	`91`	`static`
`92`	`92`	`{`
`93`		`- int max = Arrays.stream(CharStringCommand.values()).mapToInt(CharStringCommand::getValue)`
`94`		`- .max().orElseThrow();`
	`93`	`+ CharStringCommand[] values = CharStringCommand.values();`
	`94`	`+ int max = Arrays.stream(values).mapToInt(CharStringCommand::getValue).max().orElseThrow();`
`95`	`95`	`COMMANDS_BY_VALUE = new CharStringCommand[max + 1];`
`96`		`- Arrays.stream(CharStringCommand.values()).forEach(c -> COMMANDS_BY_VALUE[c.getValue()] = c);`
	`96`	`+ Arrays.stream(values).forEach(c -> COMMANDS_BY_VALUE[c.getValue()] = c);`
`97`	`97`	`}`
`98`	`98`
`99`	`99`	`private final Type1KeyWord type1KeyWord;`