Skip to content

Commit a2d376b

Browse files
committed
PDFBOX-5936: refactor for future change, the list of potention issuers is already in getCertificateSet() result
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1923254 13f79535-47bb-0310-9956-ffa450edef68
1 parent db453e3 commit a2d376b

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

examples/src/main/java/org/apache/pdfbox/examples/signature/validation/AddValidationInformation.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -445,9 +445,9 @@ private void addCrlRevocationInfo(CertSignatureInformation certInfo)
445445
CertificateVerificationException, URISyntaxException
446446
{
447447
X509CRL crl = CRLVerifier.downloadCRLFromWeb(certInfo.getCrlUrl());
448-
X509Certificate issuerCertificate = certInfo.getIssuerCertificate();
449448

450449
// find the issuer certificate (usually issuer of signature certificate)
450+
X509Certificate issuerCertificate = null;
451451
for (X509Certificate certificate : certInformationHelper.getCertificateSet())
452452
{
453453
if (certificate.getSubjectX500Principal().equals(crl.getIssuerX500Principal()))
@@ -456,6 +456,10 @@ private void addCrlRevocationInfo(CertSignatureInformation certInfo)
456456
break;
457457
}
458458
}
459+
if (issuerCertificate == null)
460+
{
461+
throw new CertificateVerificationException("Can't find issuer of CRL for " + certInfo.getCrlUrl());
462+
}
459463
crl.verify(issuerCertificate.getPublicKey(), SecurityProvider.getProvider().getName());
460464
CRLVerifier.checkRevocation(crl, certInfo.getCertificate(), signDate.getTime(), certInfo.getCrlUrl());
461465
COSStream crlStream = writeDataToStream(crl.getEncoded());

0 commit comments

Comments
 (0)