PDFBOX-5660: optimize, as suggested by Valery Bokov; closes #237

THausherr · THausherr · commit a8569a920b57 · 2025-08-30T19:20:31.000Z
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1928137 13f79535-47bb-0310-9956-ffa450edef68
diff --git a/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/common/PDNumberTreeNode.java b/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/common/PDNumberTreeNode.java
@@ -180,12 +180,13 @@ public Map<Integer,COSObjectable> getNumbers()  throws IOException
         COSArray numbersArray = node.getCOSArray(COSName.NUMS);
         if (numbersArray != null)
         {
-            indices = new HashMap<>();
-            if (numbersArray.size() % 2 != 0)
+            int size = numbersArray.size();
+            indices = new HashMap<>(size / 2);
+            if (size % 2 != 0)
             {
-                LOG.warn("Numbers array has odd size: {}", numbersArray.size());
+                LOG.warn("Numbers array has odd size: {}", size);
             }
-            for (int i = 0; i + 1 < numbersArray.size(); i += 2)
+            for (int i = 0; i + 1 < size; i += 2)
             {
                 COSBase base = numbersArray.getObject(i);
                 if (!(base instanceof COSInteger))

Original file line number	Diff line number	Diff line change
`@@ -180,12 +180,13 @@ public Map<Integer,COSObjectable> getNumbers() throws IOException`
`180`	`180`	`COSArray numbersArray = node.getCOSArray(COSName.NUMS);`
`181`	`181`	`if (numbersArray != null)`
`182`	`182`	`{`
`183`		`- indices = new HashMap<>();`
`184`		`- if (numbersArray.size() % 2 != 0)`
	`183`	`+ int size = numbersArray.size();`
	`184`	`+ indices = new HashMap<>(size / 2);`
	`185`	`+ if (size % 2 != 0)`
`185`	`186`	`{`
`186`		`- LOG.warn("Numbers array has odd size: {}", numbersArray.size());`
	`187`	`+ LOG.warn("Numbers array has odd size: {}", size);`
`187`	`188`	`}`
`188`		`- for (int i = 0; i + 1 < numbersArray.size(); i += 2)`
	`189`	`+ for (int i = 0; i + 1 < size; i += 2)`
`189`	`190`	`{`
`190`	`191`	`COSBase base = numbersArray.getObject(i);`
`191`	`192`	`if (!(base instanceof COSInteger))`