PDFBOX-5660: optimize, as suggested by Valery Bokov; closes #259

THausherr · THausherr · commit b0bc12509b56 · 2025-09-23T06:38:00.000Z
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1928700 13f79535-47bb-0310-9956-ffa450edef68
diff --git a/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/action/PDActionLaunch.java b/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/action/PDActionLaunch.java
@@ -17,6 +17,7 @@
 package org.apache.pdfbox.pdmodel.interactive.action;
 
 import java.io.IOException;
+import org.apache.pdfbox.cos.COSBase;
 import org.apache.pdfbox.cos.COSBoolean;
 
 import org.apache.pdfbox.cos.COSDictionary;
@@ -211,9 +212,10 @@ public void setP( String p )
      */
     public OpenMode getOpenInNewWindow()
     {
-        if (getCOSObject().getDictionaryObject(COSName.NEW_WINDOW) instanceof COSBoolean)
+        COSBase dictionaryObject = getCOSObject().getDictionaryObject(COSName.NEW_WINDOW);
+        if (dictionaryObject instanceof COSBoolean)
         {
-            COSBoolean b = (COSBoolean) getCOSObject().getDictionaryObject(COSName.NEW_WINDOW);
+            COSBoolean b = (COSBoolean) dictionaryObject;
             return b.getValue() ? OpenMode.NEW_WINDOW : OpenMode.SAME_WINDOW;
         }
         return OpenMode.USER_PREFERENCE;
diff --git a/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/action/PDActionRemoteGoTo.java b/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/action/PDActionRemoteGoTo.java
@@ -118,9 +118,10 @@ public void setD( COSBase d )
      */
     public OpenMode getOpenInNewWindow()
     {
-        if (getCOSObject().getDictionaryObject(COSName.NEW_WINDOW) instanceof COSBoolean)
+        COSBase dictionaryObject = getCOSObject().getDictionaryObject(COSName.NEW_WINDOW);
+        if (dictionaryObject instanceof COSBoolean)
         {
-            COSBoolean b = (COSBoolean) getCOSObject().getDictionaryObject(COSName.NEW_WINDOW);
+            COSBoolean b = (COSBoolean) dictionaryObject;
             return b.getValue() ? OpenMode.NEW_WINDOW : OpenMode.SAME_WINDOW;
         }
         return OpenMode.USER_PREFERENCE;

Original file line number	Diff line number	Diff line change
`@@ -17,6 +17,7 @@`
`17`	`17`	`package org.apache.pdfbox.pdmodel.interactive.action;`
`18`	`18`
`19`	`19`	`import java.io.IOException;`
	`20`	`+import org.apache.pdfbox.cos.COSBase;`
`20`	`21`	`import org.apache.pdfbox.cos.COSBoolean;`
`21`	`22`
`22`	`23`	`import org.apache.pdfbox.cos.COSDictionary;`
`@@ -211,9 +212,10 @@ public void setP( String p )`
`211`	`212`	`*/`
`212`	`213`	`public OpenMode getOpenInNewWindow()`
`213`	`214`	`{`
`214`		`- if (getCOSObject().getDictionaryObject(COSName.NEW_WINDOW) instanceof COSBoolean)`
	`215`	`+ COSBase dictionaryObject = getCOSObject().getDictionaryObject(COSName.NEW_WINDOW);`
	`216`	`+ if (dictionaryObject instanceof COSBoolean)`
`215`	`217`	`{`
`216`		`- COSBoolean b = (COSBoolean) getCOSObject().getDictionaryObject(COSName.NEW_WINDOW);`
	`218`	`+ COSBoolean b = (COSBoolean) dictionaryObject;`
`217`	`219`	`return b.getValue() ? OpenMode.NEW_WINDOW : OpenMode.SAME_WINDOW;`
`218`	`220`	`}`
`219`	`221`	`return OpenMode.USER_PREFERENCE;`
Original file line number	Diff line number	Diff line change
`@@ -118,9 +118,10 @@ public void setD( COSBase d )`
`118`	`118`	`*/`
`119`	`119`	`public OpenMode getOpenInNewWindow()`
`120`	`120`	`{`
`121`		`- if (getCOSObject().getDictionaryObject(COSName.NEW_WINDOW) instanceof COSBoolean)`
	`121`	`+ COSBase dictionaryObject = getCOSObject().getDictionaryObject(COSName.NEW_WINDOW);`
	`122`	`+ if (dictionaryObject instanceof COSBoolean)`
`122`	`123`	`{`
`123`		`- COSBoolean b = (COSBoolean) getCOSObject().getDictionaryObject(COSName.NEW_WINDOW);`
	`124`	`+ COSBoolean b = (COSBoolean) dictionaryObject;`
`124`	`125`	`return b.getValue() ? OpenMode.NEW_WINDOW : OpenMode.SAME_WINDOW;`
`125`	`126`	`}`
`126`	`127`	`return OpenMode.USER_PREFERENCE;`