Skip to content

Commit b9fd9df

Browse files
committed
PDFBOX-5963: add logging + comment
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1924036 13f79535-47bb-0310-9956-ffa450edef68
1 parent d63472a commit b9fd9df

File tree

1 file changed

+8
-0
lines changed

1 file changed

+8
-0
lines changed

pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/encoding/DictionaryEncoding.java

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,8 @@
1818

1919
import java.util.HashMap;
2020
import java.util.Map;
21+
import org.apache.logging.log4j.LogManager;
22+
import org.apache.logging.log4j.Logger;
2123
import org.apache.pdfbox.cos.COSArray;
2224
import org.apache.pdfbox.cos.COSBase;
2325
import org.apache.pdfbox.cos.COSDictionary;
@@ -31,6 +33,8 @@
3133
*/
3234
public class DictionaryEncoding extends Encoding
3335
{
36+
private static final Logger LOG = LogManager.getLogger(DictionaryEncoding.class);
37+
3438
private final COSDictionary encoding;
3539
private final Encoding baseEncoding;
3640
private final Map<Integer, String> differences = new HashMap<>();
@@ -80,6 +84,10 @@ public DictionaryEncoding(COSDictionary fontEncoding)
8084
baseEncoding = Encoding.getInstance(name); // null when the name is invalid
8185
if (baseEncoding != null)
8286
{
87+
// PDFBOX-5963
88+
// PDF Specification: "Differences array shall specify the complete character
89+
// encoding for this font" but other viewers read it, thus we do too.
90+
LOG.warn("/BaseEncoding in type 3 font");
8391
codeToName.putAll(baseEncoding.codeToName);
8492
inverted.putAll(baseEncoding.inverted);
8593
}

0 commit comments

Comments
 (0)