PDFBOX-5660: optimize, as suggested by Valery Bokov, closes #360

THausherr · THausherr · commit c5ff6e3952aa · 2025-12-02T20:21:29.000Z
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1930211 13f79535-47bb-0310-9956-ffa450edef68
diff --git a/tools/src/main/java/org/apache/pdfbox/tools/imageio/JPEGUtil.java b/tools/src/main/java/org/apache/pdfbox/tools/imageio/JPEGUtil.java
@@ -78,8 +78,9 @@ static void updateMetadata(IIOMetadata metadata, int dpi) throws IIOInvalidTreeE
             jfifChild.setAttribute("minorVersion", "2");
         }
         jfifChild.setAttribute("resUnits", "1"); // inch
-        jfifChild.setAttribute("Xdensity", Integer.toString(dpi));
-        jfifChild.setAttribute("Ydensity", Integer.toString(dpi));
+        String dpiString = Integer.toString(dpi);
+        jfifChild.setAttribute("Xdensity", dpiString);
+        jfifChild.setAttribute("Ydensity", dpiString);
         if (jfifChild.getAttribute("thumbWidth").isEmpty())
         {
             jfifChild.setAttribute("thumbWidth", "0");

Original file line number	Diff line number	Diff line change
`@@ -78,8 +78,9 @@ static void updateMetadata(IIOMetadata metadata, int dpi) throws IIOInvalidTreeE`
`78`	`78`	`jfifChild.setAttribute("minorVersion", "2");`
`79`	`79`	`}`
`80`	`80`	`jfifChild.setAttribute("resUnits", "1"); // inch`
`81`		`- jfifChild.setAttribute("Xdensity", Integer.toString(dpi));`
`82`		`- jfifChild.setAttribute("Ydensity", Integer.toString(dpi));`
	`81`	`+ String dpiString = Integer.toString(dpi);`
	`82`	`+ jfifChild.setAttribute("Xdensity", dpiString);`
	`83`	`+ jfifChild.setAttribute("Ydensity", dpiString);`
`83`	`84`	`if (jfifChild.getAttribute("thumbWidth").isEmpty())`
`84`	`85`	`{`
`85`	`86`	`jfifChild.setAttribute("thumbWidth", "0");`